Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 2294373002: Certificate Transparency: Remove the obsolete invalid sct status. (Closed)
Patch Set: Use uint32_t as enum base Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/website_settings/website_settings.h" 5 #include "chrome/browser/ui/website_settings/website_settings.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_NO_CT 190 return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_NO_CT
191 : IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_NO_CT); 191 : IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_NO_CT);
192 192
193 // Any valid SCT. 193 // Any valid SCT.
194 if (CertificateTransparencyStatusMatchAny(sct_verify_statuses, 194 if (CertificateTransparencyStatusMatchAny(sct_verify_statuses,
195 net::ct::SCT_STATUS_OK)) 195 net::ct::SCT_STATUS_OK))
196 return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_CT_VERIFIED 196 return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_CT_VERIFIED
197 : IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_VERIFIED); 197 : IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_VERIFIED);
198 198
199 // Any invalid SCT. 199 // Any invalid SCT.
200 if (CertificateTransparencyStatusMatchAny(sct_verify_statuses, 200 if (CertificateTransparencyStatusMatchAny(
201 net::ct::SCT_STATUS_INVALID) ||
202 CertificateTransparencyStatusMatchAny(
203 sct_verify_statuses, net::ct::SCT_STATUS_INVALID_TIMESTAMP) || 201 sct_verify_statuses, net::ct::SCT_STATUS_INVALID_TIMESTAMP) ||
204 CertificateTransparencyStatusMatchAny( 202 CertificateTransparencyStatusMatchAny(
205 sct_verify_statuses, net::ct::SCT_STATUS_INVALID_SIGNATURE)) 203 sct_verify_statuses, net::ct::SCT_STATUS_INVALID_SIGNATURE))
206 return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_CT_INVALID 204 return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_CT_INVALID
207 : IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_INVALID); 205 : IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_INVALID);
208 206
209 // All SCTs are from unknown logs. 207 // All SCTs are from unknown logs.
210 return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_CT_UNVERIFIED 208 return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_CT_UNVERIFIED
211 : IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_UNVERIFIED); 209 : IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_UNVERIFIED);
212 } 210 }
(...skipping 597 matching lines...) Expand 10 before | Expand all | Expand 10 after
810 info.connection_status = site_connection_status_; 808 info.connection_status = site_connection_status_;
811 info.connection_status_description = 809 info.connection_status_description =
812 UTF16ToUTF8(site_connection_details_); 810 UTF16ToUTF8(site_connection_details_);
813 info.identity_status = site_identity_status_; 811 info.identity_status = site_identity_status_;
814 info.identity_status_description = 812 info.identity_status_description =
815 UTF16ToUTF8(site_identity_details_); 813 UTF16ToUTF8(site_identity_details_);
816 info.cert_id = cert_id_; 814 info.cert_id = cert_id_;
817 info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_; 815 info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_;
818 ui_->SetIdentityInfo(info); 816 ui_->SetIdentityInfo(info);
819 } 817 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698