Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2115)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 2294363002: Output group nodes as containers (Closed)
Patch Set: Fix tests: add rule for date, inputTime, and clear leave rule for group. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
index f54134a7f5a3e7de1bd56d6f9d21b62dafd4aceb..d7c94b8ccf0db2a42b76e463c0cd908a30888c0e 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
@@ -186,7 +186,8 @@ Output.ROLE_INFO_ = {
msgId: 'role_grid'
},
group: {
- msgId: 'role_group'
+ msgId: 'role_group',
+ inherits: 'abstractContainer'
},
heading: {
msgId: 'role_heading',
@@ -419,7 +420,8 @@ Output.RULES = {
braille: ''
},
abstractContainer: {
- enter: '$nameFromNode $role $description',
+ enter: '$nameFromNode $role $state $description',
+ speak: '$descendants $name $value $state $role $description',
leave: '@exited_container($role)'
},
alert: {
@@ -439,6 +441,10 @@ Output.RULES = {
speak: '$if($checked, $earcon(CHECK_ON), $earcon(CHECK_OFF)) ' +
'$name $role $checked $description'
},
+ date: {
+ enter: '$nameFromNode $role $description',
+ speak: '$name $value $state $role $description'
+ },
dialog: {
enter: '$nameFromNode $role $description'
},
@@ -449,6 +455,11 @@ Output.RULES = {
grid: {
enter: '$nameFromNode $role $description'
},
+ group: {
+ enter: '$nameFromNode $state $description',
+ speak: '$descendants $name $value $state $description',
+ leave: ''
+ },
heading: {
enter: '!relativePitch(hierarchicalLevel) ' +
'$nameFromNode= @tag_h+$hierarchicalLevel',
@@ -458,6 +469,10 @@ Output.RULES = {
inlineTextBox: {
speak: '$name='
},
+ inputTime: {
+ enter: '$nameFromNode $role $description',
+ speak: '$name $value $state $role $description'
+ },
link: {
enter: '$nameFromNode= $if($visited, @visited_link, $role)',
speak: '$name= $if($visited, @visited_link, $role) $description'
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698