Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2294363002:
Output group nodes as containers (Closed)
|
Created:
4 years, 3 months ago by David Tseng Modified:
4 years, 3 months ago Reviewers:
dmazzoni CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOutput group nodes as containers
See bug for more details.
In addition, abstract containers should output state since authors can apply aria state attributes on the node.
BUG=641769, 641759
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/11d1d2bf1365a4e22149fc624a10a24944c8c0dd
Cr-Commit-Position: refs/heads/master@{#416307}
Patch Set 1 #Patch Set 2 : Mod output rules. #Patch Set 3 : Fix tests: add rule for date, inputTime, and clear leave rule for group. #
Messages
Total messages: 23 (16 generated)
Description was changed from ========== Output group nodes as containers See bug for more details. In addition, abstract containers should output state since authors can apply aria state attributes on the node. BUG= ========== to ========== Output group nodes as containers See bug for more details. In addition, abstract containers should output state since authors can apply aria state attributes on the node. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Output group nodes as containers See bug for more details. In addition, abstract containers should output state since authors can apply aria state attributes on the node. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Output group nodes as containers See bug for more details. In addition, abstract containers should output state since authors can apply aria state attributes on the node. BUG=641769 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org
Description was changed from ========== Output group nodes as containers See bug for more details. In addition, abstract containers should output state since authors can apply aria state attributes on the node. BUG=641769 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Output group nodes as containers See bug for more details. In addition, abstract containers should output state since authors can apply aria state attributes on the node. BUG=641769,641759 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Are you sure you want to speak the role for a group? I feel like "group" is almost never used for anything meaningful. I do agree about speaking everything else. What would you think about making '$descendants $name $value $state $description' the default for all roles if they don't have any more specific rules? There are probably a few other generic roles that can be used as containers that we might not be handling. Perhaps a catch-all would be better than adding a rule just for "group".
On Wed, Aug 31, 2016 at 11:26 AM, <dmazzoni@chromium.org> wrote: > Are you sure you want to speak the role for a group? I feel like "group" is > almost never used for anything meaningful. > > I do agree about speaking everything else. > > Done. > What would you think about making '$descendants $name $value $state > $description' the default for all roles if they don't have any more > specific > rules? > > There are probably a few other generic roles that can be used as containers > that > we might not be handling. Perhaps a catch-all would be better than adding > a rule > just for "group". > > Descendants might be very noisy, so I would prefer to limit it to a known list of containers. How about for all containers? > > https://codereview.chromium.org/2294363002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm
The CQ bit was checked by dtseng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dtseng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dtseng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2294363002/#ps40001 (title: "Fix tests: add rule for date, inputTime, and clear leave rule for group.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Output group nodes as containers See bug for more details. In addition, abstract containers should output state since authors can apply aria state attributes on the node. BUG=641769,641759 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Output group nodes as containers See bug for more details. In addition, abstract containers should output state since authors can apply aria state attributes on the node. BUG=641769,641759 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Output group nodes as containers See bug for more details. In addition, abstract containers should output state since authors can apply aria state attributes on the node. BUG=641769,641759 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Output group nodes as containers See bug for more details. In addition, abstract containers should output state since authors can apply aria state attributes on the node. BUG=641769,641759 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/11d1d2bf1365a4e22149fc624a10a24944c8c0dd Cr-Commit-Position: refs/heads/master@{#416307} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/11d1d2bf1365a4e22149fc624a10a24944c8c0dd Cr-Commit-Position: refs/heads/master@{#416307} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
