infra/bots/recipes/swarm_trigger.py - Issue 2294353002: Add and use a clang_linux asset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipes/swarm_trigger.py

Issue 2294353002: Add and use a clang_linux asset. (Closed)

Patch Set: copy libstdc++.so.6 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/bots/recipes/swarm_trigger.py

diff --git a/infra/bots/recipes/swarm_trigger.py b/infra/bots/recipes/swarm_trigger.py

index f512f770d6ec6ca5a6de3e1af5d78a9f87042df9..a0cfd74a20a44f886d69ef3cf78592bde41bd865 100644

--- a/infra/bots/recipes/swarm_trigger.py

+++ b/infra/bots/recipes/swarm_trigger.py

@@ -361,6 +361,9 @@ def compile_steps_swarm(api, builder_cfg, got_revision, infrabots_dir):

else:

cipd_packages.append(cipd_pkg(api, infrabots_dir, 'android_ndk_linux'))

+ if 'Ubuntu' in api.properties['buildername']:

+ cipd_packages.append(cipd_pkg(api, infrabots_dir, 'clang_linux'))

borenet 2016/08/31 18:59:26 Shouldn't this only be for Clang bots?

mtklein 2016/08/31 19:05:48 Ideally, yes. However... all the *SAN bots claim

borenet 2016/08/31 19:08:09 Yeah, we should probably rename them. In the mean

# Windows bots require a toolchain.

if 'Win' in builder_name:

version_file = infrabots_dir.join('assets', 'win_toolchain', 'VERSION')