Add and use a clang_linux asset.

Add and use a clang_linux asset.

This gives us a consistent Clang toolchain on Linux bots,
most importantly for *SAN bots.  It's ~300MB unpacked.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294353002

Committed: https://skia.googlesource.com/skia/+/da8f6546da87ff72db785cef268b176547541fed

[mtklein_C, 2016-08-31 17:15:19]

Description was changed from

==========
Add a clang_linux asset.

This gives us a consistent Clang toolchain on Linux bots,
most importantly for *SAN bots.  It's ~300MB unpacked.


BUG=skia:
==========

to

==========
Add a clang_linux asset.

This gives us a consistent Clang toolchain on Linux bots,
most importantly for *SAN bots.  It's ~300MB unpacked.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294353002
==========

[mtklein_C, 2016-08-31 17:56:08]

Description was changed from

==========
Add a clang_linux asset.

This gives us a consistent Clang toolchain on Linux bots,
most importantly for *SAN bots.  It's ~300MB unpacked.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294353002
==========

to

==========
Add and use a clang_linux asset.

This gives us a consistent Clang toolchain on Linux bots,
most importantly for *SAN bots.  It's ~300MB unpacked.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294353002
==========

[mtklein_C, 2016-08-31 18:49:35]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 18:49:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-31 18:55:50]

mtklein@chromium.org changed reviewers:
+ borenet@google.com, jcgregorio@google.com

[borenet, 2016-08-31 18:59:26]

https://codereview.chromium.org/2294353002/diff/80001/infra/bots/recipes/swar...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2294353002/diff/80001/infra/bots/recipes/swar...
infra/bots/recipes/swarm_trigger.py:365: cipd_packages.append(cipd_pkg(api,
infrabots_dir, 'clang_linux'))
Shouldn't this only be for Clang bots?

[mtklein, 2016-08-31 19:05:47]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-08-31 19:05:48]

https://codereview.chromium.org/2294353002/diff/80001/infra/bots/recipes/swar...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2294353002/diff/80001/infra/bots/recipes/swar...
infra/bots/recipes/swarm_trigger.py:365: cipd_packages.append(cipd_pkg(api,
infrabots_dir, 'clang_linux'))
On 2016/08/31 18:59:26, borenet wrote:
> Shouldn't this only be for Clang bots?

Ideally, yes.  However... all the *SAN bots claim to be -GCC- despite actually
using Clang today.  I guess we should just rename them?

[borenet, 2016-08-31 19:08:10]

https://codereview.chromium.org/2294353002/diff/80001/infra/bots/recipes/swar...
File infra/bots/recipes/swarm_trigger.py (right):

https://codereview.chromium.org/2294353002/diff/80001/infra/bots/recipes/swar...
infra/bots/recipes/swarm_trigger.py:365: cipd_packages.append(cipd_pkg(api,
infrabots_dir, 'clang_linux'))
On 2016/08/31 19:05:48, mtklein wrote:
> On 2016/08/31 18:59:26, borenet wrote:
> > Shouldn't this only be for Clang bots?
> 
> Ideally, yes.  However... all the *SAN bots claim to be -GCC- despite actually
> using Clang today.  I guess we should just rename them?

Yeah, we should probably rename them.  In the meantime can we change this to
Ubuntu && (Clang || SAN) ?

[mtklein_C, 2016-08-31 19:14:36]

On 2016/08/31 at 19:08:10, borenet wrote:
>
https://codereview.chromium.org/2294353002/diff/80001/infra/bots/recipes/swar...
> File infra/bots/recipes/swarm_trigger.py (right):
> 
>
https://codereview.chromium.org/2294353002/diff/80001/infra/bots/recipes/swar...
> infra/bots/recipes/swarm_trigger.py:365: cipd_packages.append(cipd_pkg(api,
infrabots_dir, 'clang_linux'))
> On 2016/08/31 19:05:48, mtklein wrote:
> > On 2016/08/31 18:59:26, borenet wrote:
> > > Shouldn't this only be for Clang bots?
> > 
> > Ideally, yes.  However... all the *SAN bots claim to be -GCC- despite
actually
> > using Clang today.  I guess we should just rename them?
> 
> Yeah, we should probably rename them.  In the meantime can we change this to
Ubuntu && (Clang || SAN) ?

PTAL?

[mtklein_C, 2016-08-31 19:15:44]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 19:15:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[borenet, 2016-08-31 19:19:34]

LGTM

[mtklein_C, 2016-08-31 19:19:47]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-08-31 19:19:48]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:19:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:35:25]

Description was changed from

==========
Add and use a clang_linux asset.

This gives us a consistent Clang toolchain on Linux bots,
most importantly for *SAN bots.  It's ~300MB unpacked.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294353002
==========

to

==========
Add and use a clang_linux asset.

This gives us a consistent Clang toolchain on Linux bots,
most importantly for *SAN bots.  It's ~300MB unpacked.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294353002

Committed:
https://skia.googlesource.com/skia/+/da8f6546da87ff72db785cef268b176547541fed
==========

[commit-bot: I haz the power, 2016-08-31 19:35:27]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/da8f6546da87ff72db785cef268b176547541fed