Update FrameNavigationEntry members when setting PageState.

Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY=true

Committed: https://crrev.com/04a322f25adf8b9cab272e985f44db9a01814450
Cr-Commit-Position: refs/heads/master@{#415812}

[nasko, 2016-08-31 16:51:02]

Description was changed from

==========
Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
==========

to

==========
Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2016-08-31 16:51:07]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 16:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 17:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 17:14:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nasko, 2016-08-31 18:10:42]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[nasko, 2016-08-31 18:10:57]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-31 18:13:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 18:30:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 18:30:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[nasko, 2016-08-31 18:55:27]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 18:56:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:20:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:20:30]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[nasko, 2016-08-31 20:52:07]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 20:53:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2016-08-31 20:56:29]

nasko@chromium.org changed reviewers:
+ creis@chromium.org

[nasko, 2016-08-31 20:56:30]

Hey Charlie,
Can you review this CL for me? It updates the setting of PageState on
FrameNavigationEntry to copy the ISN/DSN to the FNE itself and avoid potential
mismatches.
Thanks in advance!
Nasko

[Charlie Reis, 2016-08-31 22:07:22]

Thanks!  LGTM.

[commit-bot: I haz the power, 2016-08-31 22:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 22:53:33]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nasko, 2016-08-31 23:04:36]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-31 23:05:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2016-08-31 23:55:22]

Description was changed from

==========
Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY
==========

[nasko, 2016-08-31 23:55:29]

The CQ bit was unchecked by nasko@chromium.org

[nasko, 2016-08-31 23:55:49]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-31 23:56:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2016-08-31 23:57:26]

The CQ bit was unchecked by nasko@chromium.org

[nasko, 2016-08-31 23:58:35]

Description was changed from

==========
Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY
==========

to

==========
Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY=true
==========

[nasko, 2016-08-31 23:58:45]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-31 23:59:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 00:01:11]

Description was changed from

==========
Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY=true
==========

to

==========
Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-01 00:01:13]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-01 00:03:35]

Description was changed from

==========
Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY=true
==========

to

==========
Update FrameNavigationEntry members when setting PageState.

PageState contains data that is duplicated in the actual member variables
of FrameNavigationEntry. When the PageState is set for a FrameNavigationEntry
the duplicate entries should not mismatch, so this CL is adding code to
explicitly set them.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY=true

Committed: https://crrev.com/04a322f25adf8b9cab272e985f44db9a01814450
Cr-Commit-Position: refs/heads/master@{#415812}
==========

[commit-bot: I haz the power, 2016-09-01 00:03:36]

Patchset 3 (id:??) landed as
https://crrev.com/04a322f25adf8b9cab272e985f44db9a01814450
Cr-Commit-Position: refs/heads/master@{#415812}