Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2294313002: Let only the root layer paint root background (Closed)

Created:
4 years, 3 months ago by Xianzhu
Modified:
4 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let only the root layer paint root background When the viewport has fixed background, we may create a dedicated GraphicsLayer (CompositedLayerMapping::m_backgroundLayer) for the root background. Previously we used PaintLayerPaintingRootBackgroundOnly and PaintLayerPaintingCompositingForegroundPhase flags when painting the layer. The second flag was necessary before we refactored viewport background painting into ViewPainter, because we needed the layout objects of the document element or the body element to paint the viewport background. Now we need only the root layer to paint root background. BUG=595839 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/f218841e39d1cb7bad5a0711081e75042bca316e Cr-Commit-Position: refs/heads/master@{#415694}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 3 chunks +4 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
Xianzhu
4 years, 3 months ago (2016-08-31 15:58:43 UTC) #5
chrishtr
lgtm
4 years, 3 months ago (2016-08-31 18:34:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294313002/20001
4 years, 3 months ago (2016-08-31 18:35:20 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 18:39:23 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:42:19 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f218841e39d1cb7bad5a0711081e75042bca316e
Cr-Commit-Position: refs/heads/master@{#415694}

Powered by Google App Engine
This is Rietveld 408576698