Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2294283002: Stop sniffing 'audio/', 'video/', and 'text/csv' into script. (Closed)

Created:
4 years, 3 months ago by Mike West
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, posciak+watch_chromium.org, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop sniffing 'audio/', 'video/', and 'text/csv' into script. Currently, `<script src="whatever"></script>` will execute the resource at `whatever` as long as it returns a non-`image/*` MIME-type (and doesn't opt-in to additional protection by sending an `X-Content-Type-Options: nosniff` header). This patch tightens that to exclude `text/csv` as well as `audio/*` and `video/*` by default. Spec: https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-mime-type? Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AHsFvhHzh1o/GHj6QCdMAAAJ Discussion: https://github.com/whatwg/fetch/issues/337 BUG=433049 Committed: https://crrev.com/14bc0a5f5b710feb11504db0432c3719a2216aaa Cr-Commit-Position: refs/heads/master@{#416235}

Patch Set 1 #

Patch Set 2 : UseCounter #

Patch Set 3 : rebase #

Messages

Total messages: 18 (13 generated)
Mike West
WDYT, Jochen?
4 years, 3 months ago (2016-09-02 08:38:33 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-02 08:47:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294283002/40001
4 years, 3 months ago (2016-09-02 09:24:10 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 11:15:50 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 11:19:23 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/14bc0a5f5b710feb11504db0432c3719a2216aaa
Cr-Commit-Position: refs/heads/master@{#416235}

Powered by Google App Engine
This is Rietveld 408576698