Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2294203002: Partially update TranslateBubbleView for Harmony controls. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
ftang, sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Partially update TranslateBubbleView for Harmony controls. Should have no effect unless you pass --secondary-ui-md. BUG=635167 Committed: https://crrev.com/ec38c1703b3bff054b6a45869a6699f86aadb07b Cr-Commit-Position: refs/heads/master@{#416050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -47 lines) Patch
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 7 chunks +30 lines, -47 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
4 years, 3 months ago (2016-08-31 02:43:48 UTC) #2
sky
LGTM
4 years, 3 months ago (2016-08-31 16:21:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294203002/1
4 years, 3 months ago (2016-09-01 20:04:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 20:56:08 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:58:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec38c1703b3bff054b6a45869a6699f86aadb07b
Cr-Commit-Position: refs/heads/master@{#416050}

Powered by Google App Engine
This is Rietveld 408576698