Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2294193002: Convert editing/style/smoosh-styles-00[13].html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/style/smoosh-styles-00[13].html to use w3c test harness This patch converts "editing/style/smoosh-styles-00[13].html" to use w3c test harness to simplify test script for improving readability, and consolidates into "smoosh_styles.html" since these test scripts verifies "smoosh style". BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/6726ad114b333240bb5bf0de98ce7b9b3df6b971 Cr-Commit-Position: refs/heads/master@{#416231}

Patch Set 1 : 2016-08-31T10:41:57 #

Total comments: 2

Patch Set 2 : 2016-08-31T18:55:30 #

Total comments: 1

Patch Set 3 : 2016-09-02T14:10:21 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -430 lines) Patch
D third_party/WebKit/LayoutTests/editing/style/smoosh-styles-001.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/style/smoosh-styles-003.html View 1 chunk +0 lines, -63 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/smoosh-styles-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/smoosh-styles-001-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/smoosh-styles-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/smoosh-styles-003-expected.txt View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/smoosh-styles-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/smoosh-styles-001-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/smoosh-styles-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/smoosh-styles-003-expected.txt View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/smoosh-styles-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/smoosh-styles-001-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/smoosh-styles-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/smoosh-styles-003-expected.txt View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 26 (17 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-08-31 04:17:12 UTC) #8
yoichio
https://codereview.chromium.org/2294193002/diff/1/third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html File third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html (right): https://codereview.chromium.org/2294193002/diff/1/third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html#newcode20 third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html:20: selection.modify('move', 'forward', 'character'); Could you use collapse()?
4 years, 3 months ago (2016-08-31 08:20:25 UTC) #9
yosin_UTC9
PTAL https://codereview.chromium.org/2294193002/diff/1/third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html File third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html (right): https://codereview.chromium.org/2294193002/diff/1/third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html#newcode20 third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html:20: selection.modify('move', 'forward', 'character'); On 2016/08/31 at 08:20:25, yoichio ...
4 years, 3 months ago (2016-08-31 09:58:40 UTC) #11
yoichio
https://codereview.chromium.org/2294193002/diff/20001/third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html File third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html (right): https://codereview.chromium.org/2294193002/diff/20001/third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html#newcode20 third_party/WebKit/LayoutTests/editing/style/smoosh_styles.html:20: selection.document.execCommand('paste'); Can we have clipboard function in assert_selection to ...
4 years, 3 months ago (2016-09-01 07:56:46 UTC) #15
yosin_UTC9
PTAL Using selection.setClipboardData()
4 years, 3 months ago (2016-09-02 07:29:36 UTC) #20
yoichio
lgtm
4 years, 3 months ago (2016-09-02 08:17:55 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294193002/40001
4 years, 3 months ago (2016-09-02 09:42:02 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 11:00:06 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 11:02:24 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6726ad114b333240bb5bf0de98ce7b9b3df6b971
Cr-Commit-Position: refs/heads/master@{#416231}

Powered by Google App Engine
This is Rietveld 408576698