Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2294183002: Attempt to fix potential integer overflow in CFX_FaceCache::LoadGlyphPath(). (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Attempt to fix potential integer overflow in CFX_FaceCache::LoadGlyphPath(). BUG=641333 Committed: https://pdfium.googlesource.com/pdfium/+/21b111fcf71e4e189035f29606ca9d3fdf3ebd92

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : consistent casting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M core/fxge/ge/cfx_facecache.cpp View 1 2 3 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Lei Zhang
This does not check for large values of weight/angle/dest_width that can potentially trigger overflows. It's ...
4 years, 3 months ago (2016-08-31 19:02:31 UTC) #13
dsinclair
lgtm
4 years, 3 months ago (2016-08-31 20:23:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294183002/40001
4 years, 3 months ago (2016-08-31 20:29:27 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 20:29:42 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/21b111fcf71e4e189035f29606ca9d3fdf3e...

Powered by Google App Engine
This is Rietveld 408576698