Enable browser encoding autodetection test

Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

Removed Java-side AutodetectionTest since it is essentially a duplicated test
with only a subset of the test documents. With this removal,
WebContents interface getEncoding() can be removed too.

Notes on autodetection result:

gb18030 is detected as GBK. This is acceptable because gb18030
is a superset of GBK, and the test document doesn't contain chars
that appear only is gb18030.

ISO-8859-8-I -> windows-1255. This is also acceptable. See
https://goo.gl/bX0nxa for reference.

The test documents updated to reflect the change above are of non-UTF-8
which is not handled very well by Rietveld. Will land it manually.


BUG=597488
R=dtrainor@chromium.org, jshin@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/a86b22ea40a9500c77b28372718f3bb6df8261a9

[Jinsuk Kim, 2016-08-31 01:39:12]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 01:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jinsuk Kim, 2016-08-31 01:40:36]

Description was changed from

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

BUG=597488
==========

to

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

BUG=597488
==========

[commit-bot: I haz the power, 2016-08-31 02:46:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 02:46:14]

Dry run: This issue passed the CQ dry run.

[Jinsuk Kim, 2016-08-31 04:34:58]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 04:35:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jinsuk Kim, 2016-08-31 04:53:03]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[Jinsuk Kim, 2016-08-31 04:53:17]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-08-31 04:53:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 05:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 05:52:07]

Dry run: This issue passed the CQ dry run.

[Jinsuk Kim, 2016-08-31 09:43:45]

Description was changed from

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

BUG=597488
==========

to

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

Removed Java-side AutodetectionTest since it is essentially a duplicated test
with only a subset of the test documents. With this removal,
WebContents interface getEncoding() can be removed too.

Notes on autodetection result:

gb18030 is detected as GBK. This is acceptable because gb18030 is a superset of
GBK, and the test document doesn't contain chars that appear only is gb18030.

ISO-8859-8 -> windows-1255. This is also acceptable. See https://goo.gl/bX0nxa
for reference.

The test documents updated to reflect the change above are of non-UTF-8 which is
not handled very well by Rietveld. Will land it manually.


BUG=597488
==========

[Jinsuk Kim, 2016-08-31 09:43:45]

jinsukkim@chromium.org changed reviewers:
+ dtrainor@chromium.org, phajdan.jr@chromium.org

[Jinsuk Kim, 2016-08-31 09:44:26]

Description was changed from

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

Removed Java-side AutodetectionTest since it is essentially a duplicated test
with only a subset of the test documents. With this removal,
WebContents interface getEncoding() can be removed too.

Notes on autodetection result:

gb18030 is detected as GBK. This is acceptable because gb18030 is a superset of
GBK, and the test document doesn't contain chars that appear only is gb18030.

ISO-8859-8 -> windows-1255. This is also acceptable. See https://goo.gl/bX0nxa
for reference.

The test documents updated to reflect the change above are of non-UTF-8 which is
not handled very well by Rietveld. Will land it manually.


BUG=597488
==========

to

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

Removed Java-side AutodetectionTest since it is essentially a duplicated test
with only a subset of the test documents. With this removal,
WebContents interface getEncoding() can be removed too.

Notes on autodetection result:

gb18030 is detected as GBK. This is acceptable because gb18030
is a superset of GBK, and the test document doesn't contain chars
that appear only is gb18030.

ISO-8859-8 -> windows-1255. This is also acceptable. See 
https://goo.gl/bX0nxa for reference.

The test documents updated to reflect the change above are of non-UTF-8
which is not handled very well by Rietveld. Will land it manually.


BUG=597488
==========

[Jinsuk Kim, 2016-08-31 09:46:13]

phajdan.jr@ please review changes in chrome/{browser, test}.
dtrainor@ please review changes in chrome/android, content/.

[Paweł Hajdan Jr., 2016-08-31 14:38:32]

LGTM

[David Trainor- moved to gerrit, 2016-08-31 18:50:37]

lgtm!

[Jinsuk Kim, 2016-08-31 20:42:11]

jinsukkim@chromium.org changed reviewers:
+ thestig@chromium.org

[Jinsuk Kim, 2016-08-31 20:42:11]

thestig@chromium.org: Please review changes in 
chrome/browser/browser_encoding_browsertest.cc

[Lei Zhang, 2016-08-31 21:04:32]

thestig@chromium.org changed reviewers:
+ jshin@chromium.org

[Lei Zhang, 2016-08-31 21:04:33]

jshin: PTAL

[jungshik at Google, 2016-09-01 09:04:14]

On 2016/08/31 21:04:33, Lei Zhang wrote:
> jshin: PTAL

LGTM.  

As mentioned in the CL description, please make sure to land two test html files
(non-UTF-8)  *manually* before landing this CL. 

nit: The CL description has "ISO-8859-8 -> windows-1255". It has to be
"ISO-8859-8-I -> windows-1255".

[jungshik at Google, 2016-09-01 09:05:00]

LGTM again with the following nit taken care of.

https://codereview.chromium.org/2294173002/diff/60001/chrome/browser/browser_...
File chrome/browser/browser_encoding_browsertest.cc (right):

https://codereview.chromium.org/2294173002/diff/60001/chrome/browser/browser_...
chrome/browser/browser_encoding_browsertest.cc:208: "GBK" },
nit: 
Perhaps, it's nice to make the input file name, the expected file name and the
expected encoding all aligned. 

That is, if the expected encoding is GBK, the filenames would also use GBK.

The same is true of windows-1255.

[Lei Zhang, 2016-09-01 09:44:47]

rs lgtm

[Jinsuk Kim, 2016-09-01 23:13:15]

Description was changed from

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

Removed Java-side AutodetectionTest since it is essentially a duplicated test
with only a subset of the test documents. With this removal,
WebContents interface getEncoding() can be removed too.

Notes on autodetection result:

gb18030 is detected as GBK. This is acceptable because gb18030
is a superset of GBK, and the test document doesn't contain chars
that appear only is gb18030.

ISO-8859-8 -> windows-1255. This is also acceptable. See 
https://goo.gl/bX0nxa for reference.

The test documents updated to reflect the change above are of non-UTF-8
which is not handled very well by Rietveld. Will land it manually.


BUG=597488
==========

to

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

Removed Java-side AutodetectionTest since it is essentially a duplicated test
with only a subset of the test documents. With this removal,
WebContents interface getEncoding() can be removed too.

Notes on autodetection result:

gb18030 is detected as GBK. This is acceptable because gb18030
is a superset of GBK, and the test document doesn't contain chars
that appear only is gb18030.

ISO-8859-8-I -> windows-1255. This is also acceptable. See 
https://goo.gl/bX0nxa for reference.

The test documents updated to reflect the change above are of non-UTF-8
which is not handled very well by Rietveld. Will land it manually.


BUG=597488
==========

[Jinsuk Kim, 2016-09-01 23:16:08]

Thanks for the review.

- Updated CL description (ISO-8859-8 -> ISO-8859-8-I)
- Renamed test htmls to have the right encoding name. Note that we already have
a test html for windows-1255. Ended up renaming ISO-8859-8 to ISO-8859-8-I only,
to signify it will be detected as windows-1255.

[commit-bot: I haz the power, 2016-09-01 23:36:32]

Description was changed from

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

Removed Java-side AutodetectionTest since it is essentially a duplicated test
with only a subset of the test documents. With this removal,
WebContents interface getEncoding() can be removed too.

Notes on autodetection result:

gb18030 is detected as GBK. This is acceptable because gb18030
is a superset of GBK, and the test document doesn't contain chars
that appear only is gb18030.

ISO-8859-8-I -> windows-1255. This is also acceptable. See 
https://goo.gl/bX0nxa for reference.

The test documents updated to reflect the change above are of non-UTF-8
which is not handled very well by Rietveld. Will land it manually.


BUG=597488
==========

to

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

Removed Java-side AutodetectionTest since it is essentially a duplicated test
with only a subset of the test documents. With this removal,
WebContents interface getEncoding() can be removed too.

Notes on autodetection result:

gb18030 is detected as GBK. This is acceptable because gb18030
is a superset of GBK, and the test document doesn't contain chars
that appear only is gb18030.

ISO-8859-8-I -> windows-1255. This is also acceptable. See
https://goo.gl/bX0nxa for reference.

The test documents updated to reflect the change above are of non-UTF-8
which is not handled very well by Rietveld. Will land it manually.

BUG=597488
R=dtrainor@chromium.org, jshin@chromium.org, phajdan.jr@chromium.org,
thestig@chromium.org

Committed: https://crrev.com/a86b22ea40a9500c77b28372718f3bb6df8261a9
Cr-Commit-Position: refs/heads/master@{#416120}
==========

[commit-bot: I haz the power, 2016-09-01 23:36:33]

Patchset 4 (id:??) landed as
https://crrev.com/a86b22ea40a9500c77b28372718f3bb6df8261a9
Cr-Commit-Position: refs/heads/master@{#416120}

[Jinsuk Kim, 2016-09-01 23:38:06]

Description was changed from

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

Removed Java-side AutodetectionTest since it is essentially a duplicated test
with only a subset of the test documents. With this removal,
WebContents interface getEncoding() can be removed too.

Notes on autodetection result:

gb18030 is detected as GBK. This is acceptable because gb18030
is a superset of GBK, and the test document doesn't contain chars
that appear only is gb18030.

ISO-8859-8-I -> windows-1255. This is also acceptable. See
https://goo.gl/bX0nxa for reference.

The test documents updated to reflect the change above are of non-UTF-8
which is not handled very well by Rietveld. Will land it manually.

BUG=597488
R=dtrainor@chromium.org, jshin@chromium.org, phajdan.jr@chromium.org,
thestig@chromium.org

Committed: https://crrev.com/a86b22ea40a9500c77b28372718f3bb6df8261a9
Cr-Commit-Position: refs/heads/master@{#416120}
==========

to

==========
Enable browser encoding autodetection test

Another attempt to enable the autodetection test that has been
disabled up to now. The new autodetection lib hopefully contributed
to the stability.

Removed Java-side AutodetectionTest since it is essentially a duplicated test
with only a subset of the test documents. With this removal,
WebContents interface getEncoding() can be removed too.

Notes on autodetection result:

gb18030 is detected as GBK. This is acceptable because gb18030
is a superset of GBK, and the test document doesn't contain chars
that appear only is gb18030.

ISO-8859-8-I -> windows-1255. This is also acceptable. See
https://goo.gl/bX0nxa for reference.

The test documents updated to reflect the change above are of non-UTF-8
which is not handled very well by Rietveld. Will land it manually.


BUG=597488
R=dtrainor@chromium.org, jshin@chromium.org, phajdan.jr@chromium.org,
thestig@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/a86b22ea40a9500c77b28372718f...
==========

[Jinsuk Kim, 2016-09-01 23:38:09]

Committed patchset #4 (id:80001) manually as
a86b22ea40a9500c77b28372718f3bb6df8261a9.