Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2294163002: Fix an analysis server test. (Closed)

Created:
4 years, 3 months ago by devoncarew
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -134 lines) Patch
M pkg/analysis_server/test/integration/integration_test_methods.dart View 55 chunks +134 lines, -134 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
devoncarew
Fix an analysis server test (broken in https://codereview.chromium.org/2296023002/). https://build.chromium.org/p/client.dart/builders/pkg-linux-be/builds/4243/steps/pkg%20tests/logs/stdio
4 years, 3 months ago (2016-08-31 00:58:23 UTC) #2
devoncarew
Committed patchset #1 (id:1) manually as c3e64df2afe28901349ff48b22b75edaf76c0fb6 (presubmit successful).
4 years, 3 months ago (2016-08-31 00:58:36 UTC) #4
Brian Wilkerson
What test broke? (I'm trying to understand why it makes sense for a test to ...
4 years, 3 months ago (2016-08-31 01:01:21 UTC) #5
devoncarew
4 years, 3 months ago (2016-08-31 03:26:05 UTC) #6
Message was sent while issue was closed.
On 2016/08/31 01:01:21, Brian Wilkerson wrote:
> What test broke? (I'm trying to understand why it makes sense for a test to
> break because of whitespace in doc comments.)

This one:
https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/tool/spec/ch...

My generator changes weren't quite up to date with the generated code.

Powered by Google App Engine
This is Rietveld 408576698