Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2294133002: Make CPDF_ColorState have a CFX_ColorStateData rather than inheriting (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CPDF_ColorState have a CFX_ColorStateData rather than inheriting Committed: https://pdfium.googlesource.com/pdfium/+/ca90b8742ac780d492f96181bdd52b8d9c17a227

Patch Set 1 #

Patch Set 2 : rename Default() to SetDefault() #

Total comments: 2

Patch Set 3 : Rebase, nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -64 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_colorstate.h View 1 2 chunks +27 lines, -9 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorstate.cpp View 1 2 3 chunks +83 lines, -22 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_graphicstates.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 2 1 chunk +8 lines, -10 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 2 2 chunks +16 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-08-30 23:06:30 UTC) #4
dsinclair
lgtm w/ nit https://codereview.chromium.org/2294133002/diff/20001/core/fpdfapi/fpdf_page/cpdf_colorstate.cpp File core/fpdfapi/fpdf_page/cpdf_colorstate.cpp (right): https://codereview.chromium.org/2294133002/diff/20001/core/fpdfapi/fpdf_page/cpdf_colorstate.cpp#newcode128 core/fpdfapi/fpdf_page/cpdf_colorstate.cpp:128: } nit: {}'s not needed.
4 years, 3 months ago (2016-08-31 13:47:30 UTC) #5
Tom Sepez
https://codereview.chromium.org/2294133002/diff/20001/core/fpdfapi/fpdf_page/cpdf_colorstate.cpp File core/fpdfapi/fpdf_page/cpdf_colorstate.cpp (right): https://codereview.chromium.org/2294133002/diff/20001/core/fpdfapi/fpdf_page/cpdf_colorstate.cpp#newcode128 core/fpdfapi/fpdf_page/cpdf_colorstate.cpp:128: } On 2016/08/31 13:47:30, dsinclair wrote: > nit: {}'s ...
4 years, 3 months ago (2016-08-31 17:30:47 UTC) #6
Tom Sepez
4 years, 3 months ago (2016-08-31 17:31:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294133002/40001
4 years, 3 months ago (2016-08-31 17:31:06 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 17:41:03 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/ca90b8742ac780d492f96181bdd52b8d9c17...

Powered by Google App Engine
This is Rietveld 408576698