Issue 229413006: Don't recalculate style synchronously on hover/active.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 229413006: Don't recalculate style synchronously on hover/active. (Closed)

Created:
6 years, 8 months ago by rune

Modified:
6 years, 8 months ago

Reviewers:
esprehn, abarth-chromium

CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Don't recalculate style synchronously on hover/active. At the end of Document::updateHoverActiveState, we did a synchronous update of style and layout. That caused a :hover + onmouseover changing a class to trigger two style recalcs. There were no obvious reasons why the callers of that method expected the recalc + layout to happen either. R=abarth@chromium.org,esprehn@chromium.org BUG=361164 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171147

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -2 lines)			Patch
A	LayoutTests/fast/css/hover-recalc.html	View	1 chunk	+51 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css/hover-recalc-expected.txt	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/229413006/1

6 years, 8 months ago (2014-04-09 16:21:17 UTC) #4

Message was sent while issue was closed.

Change committed as 171147

Expand Messages | Collapse Messages