Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 2294123003: Revert "Fold HTypeInfoReadVariable of instance creation." (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fold HTypeInfoReadVariable of instance creation." These tests 'fail': language/mixin_regress_13688_test language/regress_18713_test They are marked as failing due to faulty type information ($isX and $asX) causing the wrong lookup of a type parameter of a mixin class. The CL causes the lookup to be folded, giving the correct result. The underlying issue needs to be fixed before we can proceed with this CL. TBR=sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ba11ae416f37d321a4d23f7856353b30c9eaa77c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -79 lines) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +4 lines, -64 lines 0 comments Download
D tests/compiler/dart2js_extra/27198_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
sra1
Committed patchset #1 (id:1) manually as ba11ae416f37d321a4d23f7856353b30c9eaa77c (presubmit successful).
4 years, 3 months ago (2016-08-31 02:10:52 UTC) #2
Siggi Cherem (dart-lang)
4 years, 3 months ago (2016-08-31 15:45:39 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698