Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2294123002: Refactor inspector protocol compiles. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor inspector protocol compiles. This removes the duplication of outputs from core/inspector:protocol_sources to the compiled version in core:core_generated. A new target is created core/inspector:protocol that uses get_target_outputs on :protocol_sources to avoid duplicating the sources list. To make this easier to implement, the core_config_add and core_config_remove configs list were moved to core.gni so it can be shared with multiple core build files. The inspector_protocol.gni file was changed from listing the sources to defining a template to run the script. This elimiates some duplicated code between the two users of this script. BUG= Committed: https://crrev.com/dd219210ff98b771af6a9ed93852dcf8e242a442 Cr-Commit-Position: refs/heads/master@{#415777}

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -185 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 5 chunks +1 line, -56 lines 0 comments Download
M third_party/WebKit/Source/core/core.gni View 1 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 chunk +79 lines, -70 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +26 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gni View 1 chunk +78 lines, -28 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
brettw
The context is that the core:core_generate target should no longer list all of the generated ...
4 years, 3 months ago (2016-08-30 22:59:41 UTC) #2
brettw
-> dpranke
4 years, 3 months ago (2016-08-31 21:39:06 UTC) #12
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-31 22:01:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294123002/20001
4 years, 3 months ago (2016-08-31 22:12:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 22:18:12 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:20:06 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd219210ff98b771af6a9ed93852dcf8e242a442
Cr-Commit-Position: refs/heads/master@{#415777}

Powered by Google App Engine
This is Rietveld 408576698