Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2294113003: Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage (Closed)

Created:
4 years, 3 months ago by battre
Modified:
4 years, 3 months ago
Reviewers:
stanisc, ncarter (slow)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage BUG=642482 TBR=stanisc@chromium.org,nick@chromium.org Committed: https://crrev.com/940f8f135b20b2e5bca8c76ad036eb98e142def0 Cr-Commit-Position: refs/heads/master@{#415620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/app_background_page_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294113003/1
4 years, 3 months ago (2016-08-31 12:47:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 13:31:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/940f8f135b20b2e5bca8c76ad036eb98e142def0 Cr-Commit-Position: refs/heads/master@{#415620}
4 years, 3 months ago (2016-08-31 13:33:10 UTC) #5
stanisc
4 years, 3 months ago (2016-08-31 20:53:15 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2299803002/ by stanisc@chromium.org.

The reason for reverting is: The bug is now fixed so disabling this test is no
longer needed.
See https://codereview.chromium.org/2293293002/.

Powered by Google App Engine
This is Rietveld 408576698