DevTools: Color JavaScript booleans pink

DevTools: Color JavaScript booleans pink
Highlight JavaScript booleans, null, undefined, etc as pink

BUG=none

Committed: https://crrev.com/63fed777200ff523685ab1ef58579722fb513ea9
Cr-Commit-Position: refs/heads/master@{#415538}

[einbinder, 2016-08-30 22:56:58]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-08-30 22:56:59]

ptal

[lushnikov, 2016-08-30 23:25:09]

we need multiple screenshots!

[einbinder, 2016-08-30 23:47:57]

On 2016/08/30 at 23:25:09, lushnikov wrote:
> we need multiple screenshots!

Screenshot of where the colors are used: http://i.imgur.com/pQKecLT.png

[lushnikov, 2016-08-31 00:16:27]

lushnikov@chromium.org changed reviewers:
+ pfeldman@chromium.org

[lushnikov, 2016-08-31 00:16:27]

lushnikov@chromium.org changed required reviewers:
+ pfeldman@chromium.org

[lushnikov, 2016-08-31 00:16:28]

i'm fine with these, lgtm

However, AFAIR @pfeldman was unhappy with our previous attempts to highlight
true/false, and for some reason they were not landed. 

Pavel, do you have a memory of this?

[lushnikov, 2016-08-31 00:19:57]

Description was changed from

==========
DevTools: Color JavaScript booleans pink
Highlight JavaScript booleans, null, undefined, etc as pink

BUG=none
==========

to

==========
DevTools: Color JavaScript booleans pink
Highlight JavaScript booleans, null, undefined, etc as pink

BUG=none
==========

[lushnikov, 2016-08-31 00:19:57]

lushnikov@chromium.org changed required reviewers:
- pfeldman@chromium.org

[lushnikov, 2016-08-31 00:20:03]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-08-31 00:20:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-08-31 00:20:58]

On 2016/08/31 00:16:28, lushnikov wrote:
> i'm fine with these, lgtm
> 
> However, AFAIR @pfeldman was unhappy with our previous attempts to highlight
> true/false, and for some reason they were not landed. 
> 
> Pavel, do you have a memory of this?

no memory, love pink!

[commit-bot: I haz the power, 2016-08-31 02:15:06]

Description was changed from

==========
DevTools: Color JavaScript booleans pink
Highlight JavaScript booleans, null, undefined, etc as pink

BUG=none
==========

to

==========
DevTools: Color JavaScript booleans pink
Highlight JavaScript booleans, null, undefined, etc as pink

BUG=none
==========

[commit-bot: I haz the power, 2016-08-31 02:15:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 02:16:42]

Description was changed from

==========
DevTools: Color JavaScript booleans pink
Highlight JavaScript booleans, null, undefined, etc as pink

BUG=none
==========

to

==========
DevTools: Color JavaScript booleans pink
Highlight JavaScript booleans, null, undefined, etc as pink

BUG=none

Committed: https://crrev.com/63fed777200ff523685ab1ef58579722fb513ea9
Cr-Commit-Position: refs/heads/master@{#415538}
==========

[commit-bot: I haz the power, 2016-08-31 02:16:43]

Patchset 1 (id:??) landed as
https://crrev.com/63fed777200ff523685ab1ef58579722fb513ea9
Cr-Commit-Position: refs/heads/master@{#415538}