Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 2294093008: Add another LookupIterator constructor, and switch to delegating constructors. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add another LookupIterator constructor, and switch to delegating constructors. This allows the constructors which simply fill in a missing parameter to do so without duplicating the constructor body. Committed: https://crrev.com/bcbbfa7dda9af6e6db2d30056b37ba58eed430f1 Cr-Commit-Position: refs/heads/master@{#39110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M src/lookup.h View 2 chunks +15 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jbroman
This adds the (isolate, receiver, name, configuration) constructor you mentioned over on https://codereview.chromium.org/2304563004/, and rewrites ...
4 years, 3 months ago (2016-09-01 21:35:33 UTC) #4
Camillo Bruni
LGTM, indeed much cleaner this way.
4 years, 3 months ago (2016-09-01 22:16:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294093008/1
4 years, 3 months ago (2016-09-01 22:22:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 22:23:39 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 22:24:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcbbfa7dda9af6e6db2d30056b37ba58eed430f1
Cr-Commit-Position: refs/heads/master@{#39110}

Powered by Google App Engine
This is Rietveld 408576698