Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2294093006: Reland of 🚀 Add dex info and static initializers to resource_sizes.py (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add dex info and static initializers to resource_sizes.py First attempt: https://codereview.chromium.org/2243343004/ Reason for reland: Now ignores placeholder .so files The goal is to have a single script that reports all .apk size related metrics. * Uses method_count.py to get dex info. * Already had static initializer logic, but now shows it even without --so_with_symbols_path. * Tweaks the static initializer count logic to sum up rather for all .so files rather than report the same metric repeatedly. TBR=rnephew@chromium.org,amineer@chromium.org BUG=609365 Committed: https://crrev.com/fe79dde87a12036cc563383e38508b8aad298fd6 Cr-Commit-Position: refs/heads/master@{#415725}

Patch Set 1 #

Patch Set 2 : Ignore empty .so files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -22 lines) Patch
M build/android/method_count.py View 1 5 chunks +8 lines, -8 lines 0 comments Download
M build/android/resource_sizes.py View 1 6 chunks +58 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
agrieve
Created Reland of 🚀 Add dex info and static initializers to resource_sizes.py
4 years, 3 months ago (2016-08-31 17:57:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294093006/70001
4 years, 3 months ago (2016-08-31 18:18:08 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 3 months ago (2016-08-31 19:36:47 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fe79dde87a12036cc563383e38508b8aad298fd6 Cr-Commit-Position: refs/heads/master@{#415725}
4 years, 3 months ago (2016-08-31 19:38:34 UTC) #8
agrieve
4 years, 3 months ago (2016-09-01 14:13:02 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:70001) has been created in
https://codereview.chromium.org/2302903002/ by agrieve@chromium.org.

The reason for reverting is: Broke it again due to crazy.libchrome.so.

Powered by Google App Engine
This is Rietveld 408576698