Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2294093003: Add conversation_key to CastEventProto message. (Closed)

Created:
4 years, 3 months ago by esum
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, byungchul, maclellant, seantopping
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add conversation_key to CastEventProto message. BUG=internal b/30114788 Committed: https://crrev.com/7c1aeadaee6700a3b0a6c76aba3c9123fb6039f7 Cr-Commit-Position: refs/heads/master@{#415524}

Patch Set 1 #

Patch Set 2 : Remove outdated comment in CastMetricsServiceClient. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chromecast/browser/metrics/cast_metrics_service_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
shumway186
4 years, 3 months ago (2016-08-30 22:37:58 UTC) #2
esum
Please see internal CL here: cl/131654836
4 years, 3 months ago (2016-08-30 22:42:19 UTC) #4
byungchul
lgtm
4 years, 3 months ago (2016-08-30 22:51:21 UTC) #6
Ilya Sherman
lgtm
4 years, 3 months ago (2016-08-30 23:54:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294093003/1
4 years, 3 months ago (2016-08-31 00:04:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 01:05:22 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 01:07:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c1aeadaee6700a3b0a6c76aba3c9123fb6039f7
Cr-Commit-Position: refs/heads/master@{#415524}

Powered by Google App Engine
This is Rietveld 408576698