Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2294093002: Reland of Background tracing: Added config option for repeated trigger behavior (patchset #1 id:1 o… (Closed)

Created:
4 years, 3 months ago by oystein (OOO til 10th of July)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Reland of Background tracing: Added config option for repeated trigger behavior (patchset #1 id:1 of https://codereview.chromium.org/2265423002/ ) Reason for revert: Re-landing with fix Original issue's description: > Revert of Background tracing: Added config option for repeated trigger behavior (patchset #1 id:1 of https://codereview.chromium.org/2247033005/ ) > > Reason for revert: > Test is flaky on builder "Android Tests" > > Builder: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests > > Failure: > https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/30899 > > Output: > BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored (run #1): > [ RUN ] BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored > [WARNING:dns_config_service_posix.cc(316)] Failed to read DnsConfig. > [ERROR:devtools_http_handler.cc(228)] Cannot start http server for devtools. Stop devtools. > ../../content/browser/tracing/background_tracing_manager_browsertest.cc:1210: Failure > Value of: BackgroundTracingManagerImpl::GetInstance()->IsTracingForTesting() > Actual: false > Expected: true > ../../content/browser/tracing/background_tracing_manager_browsertest.cc:95: Failure > Value of: value > Actual: true > Expected: expected > Which is: false > [ FAILED ] BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored, where TypeParam = and GetParam() = (188 ms) > [----------] 1 test from BackgroundTracingManagerBrowserTest (188 ms total) > > Original issue's description: > > Background tracing: Add config option to control whether or not to stop reactive tracing when a repeated trigger occurs > > > > R=simonhatch@chromium.org > > BUG=637129 > > > > Committed: https://crrev.com/fba230c24383ae08ea6d924401bdff81b46c7108 > > Cr-Commit-Position: refs/heads/master@{#412577} > > TBR=simonhatch@chromium.org,ssid@chromium.org,petrcermak@chromium.org,oysteine@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=637129 > > Committed: https://crrev.com/ccb0f2af13bf3cc4ebdcdd7a08e19b281d788897 > Cr-Commit-Position: refs/heads/master@{#413627} TBR=simonhatch@chromium.org,ssid@chromium.org,petrcermak@chromium.org,megjablon@chromium.org BUG=637129 Review-Url: https://codereview.chromium.org/2285853002 Cr-Commit-Position: refs/heads/master@{#414867} (cherry picked from commit 2f4c6f2c22a02a172845c8beb9c4effb2389af13) Committed: https://chromium.googlesource.com/chromium/src/+/b997559f8b767b1f74cd1f8c8eed408a99e52843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -4 lines) Patch
M chrome/browser/tracing/navigation_tracing.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/background_tracing_config_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_browsertest.cc View 4 chunks +80 lines, -0 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M content/browser/tracing/background_tracing_rule.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/tracing/background_tracing_rule.cc View 4 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oystein (OOO til 10th of July)
4 years, 3 months ago (2016-08-30 21:46:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b997559f8b767b1f74cd1f8c8eed408a99e52843.

Powered by Google App Engine
This is Rietveld 408576698