runtime/observatory/tests/observatory_ui/mocks/objects/objectpool.dart - Issue 2294073003: Converted Observatory class-view element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/observatory_ui/mocks/objects/objectpool.dart

Issue 2294073003: Converted Observatory class-view element (Closed)

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/observatory_ui/mocks/objects/megamorphiccache.dart ('k') | runtime/observatory/tests/observatory_ui/mocks/objects/script.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/observatory_ui/mocks/objects/objectpool.dart

diff --git a/runtime/observatory/tests/observatory_ui/mocks/objects/objectpool.dart b/runtime/observatory/tests/observatory_ui/mocks/objects/objectpool.dart

index 0124fcd99391b98769f755ee7b55a6d0ed7ac5aa..4fba8bdb11d7784038822f3fe212f4846820f21b 100644

--- a/runtime/observatory/tests/observatory_ui/mocks/objects/objectpool.dart

+++ b/runtime/observatory/tests/observatory_ui/mocks/objects/objectpool.dart

@@ -14,11 +14,12 @@ class ObjectPoolRefMock implements M.ObjectPoolRef {

class ObjectPoolMock implements M.ObjectPool {

final String id;

final M.ClassRef clazz;

+ final String vmName;

final int size;

final int length;

final Iterable<M.ObjectPoolEntry> entries;

- const ObjectPoolMock({this.id: 'objectpool-id',

+ const ObjectPoolMock({this.id: 'objectpool-id', this.vmName: 'objpool-vmName',

this.clazz: const ClassRefMock(), this.size: 1,

this.length: 0, this.entries: const []});

}