Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2294073003: Converted Observatory class-view element (Closed)
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index feb6b7414b3db4fcf8f442c68a06174ca2b2b7dc..d814421038d281da37362a683734572de639951f 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -6,6 +6,7 @@ part of app;
final _allocationProfileRepository = new AllocationProfileRepository();
final _breakpointRepository = new BreakpointRepository();
+final _classSampleProfileRepository = new ClassSampleProfileRepository();
final _classRepository = new ClassRepository();
final _contextRepository = new ContextRepository();
final _evalRepository = new EvalRepository();
@@ -24,8 +25,12 @@ final _objectstoreRepository = new ObjectStoreRepository();
final _persistentHandlesRepository = new PersistentHandlesRepository();
final _portsRepository = new PortsRepository();
final _scriptRepository = new ScriptRepository();
+final _stronglyReachangleInstancesRepository =
+ new StronglyReachableInstancesRepository();
+final _topRetainingInstancesRepository = new TopRetainingInstancesRepository();
final _typeArgumentsRepository = new TypeArgumentsRepository();
+
class IsolateNotFound implements Exception {
String isolateId;
IsolateNotFound(this.isolateId);
@@ -193,7 +198,25 @@ class InspectPage extends MatchingPage {
Future _visitObject(obj) async {
container.children = [];
await obj.reload();
- if (obj is Context) {
+ if (obj is Class) {
+ container.children = [
+ new ClassViewElement(app.vm, obj.isolate, obj, app.events,
+ app.notifications,
+ _classRepository,
+ _retainedSizeRepository,
+ _reachableSizeRepository,
+ _inboundReferencesRepository,
+ _retainingPathRepository,
+ _fieldRepository,
+ _scriptRepository,
+ _instanceRepository,
+ _evalRepository,
+ _stronglyReachangleInstancesRepository,
+ _topRetainingInstancesRepository,
+ _classSampleProfileRepository,
+ queue: app.queue)
+ ];
+ } else if (obj is Context) {
container.children = [
new ContextViewElement(app.vm, obj.isolate, obj, app.events,
app.notifications,
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/class_allocation_profile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698