Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2294073002: [Android] Fix a bug in download manager that spinner shows forever (Closed)

Created:
4 years, 3 months ago by Ian Wen
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix a bug in download manager that spinner shows forever If the backend initializes synchronously, the loading view will call hideLoadingUi() and then showLoadingUi(), which makes the loading view always visible. BUG=641262 Committed: https://crrev.com/c9d62a58d87453ae177a12dcf9fa9791243fd058 Cr-Commit-Position: refs/heads/master@{#415445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Wen
PTAL
4 years, 3 months ago (2016-08-30 20:59:17 UTC) #2
gone
lgtm
4 years, 3 months ago (2016-08-30 21:02:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294073002/1
4 years, 3 months ago (2016-08-30 21:03:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:51:07 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:53:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9d62a58d87453ae177a12dcf9fa9791243fd058
Cr-Commit-Position: refs/heads/master@{#415445}

Powered by Google App Engine
This is Rietveld 408576698