Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2293963002: SkMakeUnique.h defines skstd::make_unique<T>(Args...) (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkMakeUnique.h defines skstd::make_unique<T>(Args...) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293963002 Committed: https://skia.googlesource.com/skia/+/022c2bd37a3d5b1611928b67e0be1c30a1a0946f

Patch Set 1 #

Patch Set 2 : move to src/core #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
A src/core/SkMakeUnique.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
M src/pdf/SkDeflate.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/pdf/SkPDFDocument.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
hal.canary
take a look
4 years, 3 months ago (2016-08-30 18:20:42 UTC) #10
reed1
I think I like the idea, but definitely defer to the template experts
4 years, 3 months ago (2016-09-01 20:43:04 UTC) #12
mtklein
lgtm, looks like make_unique to me
4 years, 3 months ago (2016-09-01 20:43:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293963002/20001
4 years, 3 months ago (2016-09-02 13:24:57 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 18:29:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/022c2bd37a3d5b1611928b67e0be1c30a1a0946f

Powered by Google App Engine
This is Rietveld 408576698