Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2293933003: Remove whitespace in the <ping> element closing tag in the comp updater. (Closed)

Created:
4 years, 3 months ago by Sorin Jianu
Modified:
4 years, 3 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove whitespace in the <ping> element closing tag in the comp updater. BUG=642434 Committed: https://crrev.com/46bdd0b3be5f52262cfdd5c36cf43d4e55620797 Cr-Commit-Position: refs/heads/master@{#415469}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : Remove more whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M components/update_client/component_patcher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/update_checker.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/update_client/update_client_unittest.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M components/update_client/update_response_unittest.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Sorin Jianu
4 years, 3 months ago (2016-08-30 18:37:30 UTC) #2
Sorin Jianu
4 years, 3 months ago (2016-08-30 18:37:42 UTC) #4
waffles
lgtm https://codereview.chromium.org/2293933003/diff/1/components/update_client/update_checker.cc File components/update_client/update_checker.cc (right): https://codereview.chromium.org/2293933003/diff/1/components/update_client/update_checker.cc#newcode67 components/update_client/update_checker.cc:67: // <updatecheck /> Want to remove it from ...
4 years, 3 months ago (2016-08-30 20:27:23 UTC) #8
Sorin Jianu
Thank you! https://codereview.chromium.org/2293933003/diff/1/components/update_client/update_checker.cc File components/update_client/update_checker.cc (right): https://codereview.chromium.org/2293933003/diff/1/components/update_client/update_checker.cc#newcode67 components/update_client/update_checker.cc:67: // <updatecheck /> On 2016/08/30 20:27:22, waffles ...
4 years, 3 months ago (2016-08-30 21:50:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293933003/40001
4 years, 3 months ago (2016-08-30 21:51:31 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-30 22:42:44 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 22:44:51 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/46bdd0b3be5f52262cfdd5c36cf43d4e55620797
Cr-Commit-Position: refs/heads/master@{#415469}

Powered by Google App Engine
This is Rietveld 408576698