Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5510)

Unified Diff: chrome/installer/mac/app/Unpacker.m

Issue 2293923005: General comment cleaning / refactoring for Mac Installer (Closed)
Patch Set: Ivan fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/app/Unpacker.m
diff --git a/chrome/installer/mac/app/Unpacker.m b/chrome/installer/mac/app/Unpacker.m
index f3b9072870cc8256883c731a0ba5ee083df283e2..5d16bffdac6dc381b8e078406db699f427b61e55 100644
--- a/chrome/installer/mac/app/Unpacker.m
+++ b/chrome/installer/mac/app/Unpacker.m
@@ -49,15 +49,16 @@ static void unmount_callback(DADiskRef disk,
- (void)cleanUp {
[mountTask_ terminate];
// It's not the end of the world if this temporary directory is not removed
- // here. It will be deleted when the operating system itself decides to
- // anyway.
+ // here. The directory will be deleted when the operating system itself
+ // decides to anyway.
[[NSFileManager defaultManager] removeItemAtURL:temporaryDirectoryURL_
error:nil];
[[NSNotificationCenter defaultCenter] removeObserver:self];
}
-// TODO: the failure delegate methods need to be revised to be more meaningfully
-// deal with the errors (pipe in stderr / stdout)
+// TODO: The failure delegate methods need to be revised to meaningfully deal
+// with the errors (pipe in stderr / stdout to handle the error according to
+// what the error was).
- (void)mountDMGFromURL:(NSURL*)fileURL {
NSError* error = nil;
temporaryDirectoryURL_ = [[NSFileManager defaultManager]

Powered by Google App Engine
This is Rietveld 408576698