chrome/installer/mac/app/OmahaCommunication.h - Issue 2293923005: General comment cleaning / refactoring for Mac Installer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/OmahaCommunication.h

Issue 2293923005: General comment cleaning / refactoring for Mac Installer (Closed)

Patch Set: Ivan fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/installer/mac/app/AppDelegate.mm ('K') | « chrome/installer/mac/app/NSError+ChromeInstallerAdditions.h ('k') | chrome/installer/mac/app/OmahaCommunication.m » ('j') | chrome/installer/mac/app/copy_to_disk.sh » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_	5 #ifndef CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_

6 #define CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_	6 #define CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_

7	7

8 #import <Foundation/Foundation.h>	8 #import <Foundation/Foundation.h>

9	9

10 @class OmahaCommunication;	10 @class OmahaCommunication;

11 @protocol OmahaCommunicationDelegate	11 @protocol OmahaCommunicationDelegate

12 - (void)omahaCommunication:(OmahaCommunication*)messenger	12 - (void)omahaCommunication:(OmahaCommunication*)messenger

13 onSuccess:(NSArray*)URLs;	13 onSuccess:(NSArray*)URLs;

14 - (void)omahaCommunication:(OmahaCommunication*)messenger	14 - (void)omahaCommunication:(OmahaCommunication*)messenger

15 onFailure:(NSError*)error;	15 onFailure:(NSError*)error;

16 @end	16 @end

17	17

18 @interface OmahaCommunication : NSObject<NSURLSessionDataDelegate>	18 @interface OmahaCommunication : NSObject<NSURLSessionDataDelegate>

19	19

20 @property(nonatomic, copy) NSXMLDocument* requestXMLBody;	20 @property(nonatomic, copy) NSXMLDocument* requestXMLBody;

21 @property(nonatomic, assign) id<OmahaCommunicationDelegate> delegate;	21 @property(nonatomic, assign) id<OmahaCommunicationDelegate> delegate;

22	22

23 - (id)init;	23 - (id)init;

24 - (id)initWithBody:(NSXMLDocument*)xmlBody;	24 - (id)initWithBody:(NSXMLDocument*)xmlBody;

25	25

26 // Asks the Omaha servers for the most updated version of Chrome by sending a	26 // Asks the Omaha servers for the most updated version of Chrome.

27 // request using this function.

28 - (void)fetchDownloadURLs;	27 - (void)fetchDownloadURLs;

29	28

30 @end	29 @end

31	30

32 #endif // CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_	31 #endif // CHROME_INSTALLER_MAC_APP_OMAHACOMMUNICATION_H_

OLD	NEW