Override webrtc task_queue.cc and task_queue.h.

Override webrtc task_queue.cc and task_queue.h.
This is step 3 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Combine a roll of webrtc to Chrome and this cl  into one  cl.
The combined cl will roll in build files from  2 and  add task_queue.cc in webrtc_overrides and build task_queue_unittest.cc as part of content_unittests to test task_queue.cc in webrtc_overrides.
4... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org

[perkj_chrome, 2016-08-30 20:45:08]

Description was changed from

==========
Override webrtc task_queue.cc and task_queue.h.
This is step 4 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and
task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Roll webrtc to Chrome
4. Land this cl  that add task_queue.cc in webrtc_overrides and build
task_queue_unittest.cc as part of content_unittests to test task_queue.cc in
webrtc_overrides.
5... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org
==========

to

==========
Override webrtc task_queue.cc and task_queue.h.
This is step 4 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and
task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Roll webrtc to Chrome
4. Land this cl  that add task_queue.cc in webrtc_overrides and build
task_queue_unittest.cc as part of content_unittests to test task_queue.cc in
webrtc_overrides.
5... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org
==========

[perkj_chrome, 2016-08-30 20:45:08]

perkj@chromium.org changed reviewers:
- tommi@chromium.org

[perkj_chrome, 2016-08-30 20:51:51]

Description was changed from

==========
Override webrtc task_queue.cc and task_queue.h.
This is step 4 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and
task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Roll webrtc to Chrome
4. Land this cl  that add task_queue.cc in webrtc_overrides and build
task_queue_unittest.cc as part of content_unittests to test task_queue.cc in
webrtc_overrides.
5... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org
==========

to

==========
Override webrtc task_queue.cc and task_queue.h.
This is step 4 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and
task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Combine a roll of webrtc to Chrome and this cl  into one  cl.
The combined cl will roll roll in build files from  2 and  add task_queue.cc in
webrtc_overrides and build task_queue_unittest.cc as part of content_unittests
to test task_queue.cc in webrtc_overrides.
5... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org
==========

[perkj_chrome, 2016-08-30 20:52:07]

Description was changed from

==========
Override webrtc task_queue.cc and task_queue.h.
This is step 4 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and
task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Combine a roll of webrtc to Chrome and this cl  into one  cl.
The combined cl will roll roll in build files from  2 and  add task_queue.cc in
webrtc_overrides and build task_queue_unittest.cc as part of content_unittests
to test task_queue.cc in webrtc_overrides.
5... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org
==========

to

==========
Override webrtc task_queue.cc and task_queue.h.
This is step 4 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and
task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Combine a roll of webrtc to Chrome and this cl  into one  cl.
The combined cl will roll roll in build files from  2 and  add task_queue.cc in
webrtc_overrides and build task_queue_unittest.cc as part of content_unittests
to test task_queue.cc in webrtc_overrides.
4... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org
==========

[perkj_chrome, 2016-08-30 20:52:48]

Description was changed from

==========
Override webrtc task_queue.cc and task_queue.h.
This is step 4 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and
task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Combine a roll of webrtc to Chrome and this cl  into one  cl.
The combined cl will roll roll in build files from  2 and  add task_queue.cc in
webrtc_overrides and build task_queue_unittest.cc as part of content_unittests
to test task_queue.cc in webrtc_overrides.
4... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org
==========

to

==========
Override webrtc task_queue.cc and task_queue.h.
This is step 3 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and
task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Combine a roll of webrtc to Chrome and this cl  into one  cl.
The combined cl will roll roll in build files from  2 and  add task_queue.cc in
webrtc_overrides and build task_queue_unittest.cc as part of content_unittests
to test task_queue.cc in webrtc_overrides.
4... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org
==========

[perkj_chrome, 2016-08-30 20:53:15]

Description was changed from

==========
Override webrtc task_queue.cc and task_queue.h.
This is step 3 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and
task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Combine a roll of webrtc to Chrome and this cl  into one  cl.
The combined cl will roll roll in build files from  2 and  add task_queue.cc in
webrtc_overrides and build task_queue_unittest.cc as part of content_unittests
to test task_queue.cc in webrtc_overrides.
4... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org
==========

to

==========
Override webrtc task_queue.cc and task_queue.h.
This is step 3 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and
task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Combine a roll of webrtc to Chrome and this cl  into one  cl.
The combined cl will roll in build files from  2 and  add task_queue.cc in
webrtc_overrides and build task_queue_unittest.cc as part of content_unittests
to test task_queue.cc in webrtc_overrides.
4... Start using task queues in webrtc........

BUG=webrtc:5687
R=tommi@chromium.org
==========

[perkj_chrome, 2016-08-30 20:54:15]

perkj@chromium.org changed reviewers:
+ tommi@chromium.org

[perkj_chrome, 2016-08-30 21:25:23]

On 2016/08/30 20:54:15, perkj_chrome wrote:
> mailto:perkj@chromium.org changed reviewers:
> + mailto:tommi@chromium.org

HEj
Since we already use task queue indirectly in chrome- We use
SequencedTaskChecker that calls TaskQueue::Current()- I see no other option than
to:
1.  Land https://codereview.webrtc.org/2289203002/ cl that will break the chrome
fyi bot.
2. Do a combined webrtc roll wth this cl.

[tommi (sloooow) - chröme, 2016-08-31 18:13:28]

https://codereview.chromium.org/2293913003/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/2293913003/diff/20001/DEPS#newcode222
DEPS:222: Var('chromium_git') + '/external/webrtc/trunk/webrtc.git' + '@' +
'e5dcf5c76c793e7355be2876cd9141e4289f8c9f', # commit position 13983
since this is a roll as well, can you include information in the CL description
about the CLs you're rolling?

[tommi (sloooow) - chröme, 2016-08-31 18:13:58]

On 2016/08/31 18:13:28, tommi (chrömium) wrote:
> https://codereview.chromium.org/2293913003/diff/20001/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/2293913003/diff/20001/DEPS#newcode222
> DEPS:222: Var('chromium_git') + '/external/webrtc/trunk/webrtc.git' + '@' +
> 'e5dcf5c76c793e7355be2876cd9141e4289f8c9f', # commit position 13983
> since this is a roll as well, can you include information in the CL
description
> about the CLs you're rolling?

lgtm with a description that also includes the regular roll information.

[perkj_chrome, 2016-09-01 06:22:27]

On 2016/08/31 18:13:58, tommi (chrömium) wrote:
> On 2016/08/31 18:13:28, tommi (chrömium) wrote:
> > https://codereview.chromium.org/2293913003/diff/20001/DEPS
> > File DEPS (right):
> > 
> > https://codereview.chromium.org/2293913003/diff/20001/DEPS#newcode222
> > DEPS:222: Var('chromium_git') + '/external/webrtc/trunk/webrtc.git' + '@' +
> > 'e5dcf5c76c793e7355be2876cd9141e4289f8c9f', # commit position 13983
> > since this is a roll as well, can you include information in the CL
> description
> > about the CLs you're rolling?
> 
> lgtm with a description that also includes the regular roll information.

Sorry- This got confused. The actual combined roll and cl was landed here :
https://codereview.chromium.org/2295723004/
That includes both descriptions.