Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2293833003: [DevTools] Fix inspector/elements/iframe-load-event.html (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix inspector/elements/iframe-load-event.html BUG=493815 R=lushnikov@chromium.org Committed: https://crrev.com/7afbba8585b360b94ef4e9cc4497a93b12987587 Cr-Commit-Position: refs/heads/master@{#415534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/resources/iframe-load-event-iframe.js View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kozy
Andrey, please take a look!
4 years, 3 months ago (2016-08-30 23:16:05 UTC) #1
lushnikov
lgtm
4 years, 3 months ago (2016-08-30 23:19:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293833003/1
4 years, 3 months ago (2016-08-30 23:29:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 01:52:35 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 01:56:14 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7afbba8585b360b94ef4e9cc4497a93b12987587
Cr-Commit-Position: refs/heads/master@{#415534}

Powered by Google App Engine
This is Rietveld 408576698