Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3235)

Unified Diff: chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h

Issue 2293823002: Clean up some nits in DesktopMediaListView. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h
diff --git a/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h b/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h
index 7ca03f70fda412130396a9498c75dc952914cb96..a8108e50a1ea869b7ef92abca6238da01eb1ed76 100644
--- a/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h
+++ b/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_UI_VIEWS_DESKTOP_CAPTURE_DESKTOP_MEDIA_LIST_VIEW_H_
#define CHROME_BROWSER_UI_VIEWS_DESKTOP_CAPTURE_DESKTOP_MEDIA_LIST_VIEW_H_
+#include <memory>
+
#include "chrome/browser/media/desktop_media_list_observer.h"
#include "chrome/browser/ui/views/desktop_capture/desktop_media_source_view.h"
#include "content/public/browser/desktop_media_id.h"
@@ -58,14 +60,17 @@ class DesktopMediaListView : public views::View,
// Change the source style of this list on the fly.
void SetStyle(DesktopMediaSourceViewStyle* style);
- DesktopMediaPickerDialogView* parent_;
+ // Helper for child_at().
+ DesktopMediaSourceView* GetChild(int index);
+
+ DesktopMediaPickerDialogView* const parent_;
std::unique_ptr<DesktopMediaList> media_list_;
DesktopMediaSourceViewStyle single_style_;
DesktopMediaSourceViewStyle generic_style_;
DesktopMediaSourceViewStyle* active_style_;
- base::string16 accessible_name_;
+ const base::string16 accessible_name_;
base::WeakPtrFactory<DesktopMediaListView> weak_factory_;
« no previous file with comments | « no previous file | chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698