Don't reuse the name scope for multiple variables in DoParseLazy

Don't reuse the name scope for multiple variables in DoParseLazy

R=marja@chromium.org,verwaest@chromium.org
BUG=

Committed: https://crrev.com/1992d72bbee90ce9a1fe64056a6defb7129fe32f
Cr-Commit-Position: refs/heads/master@{#39008}

[jochen (gone - plz use gerrit), 2016-08-30 09:09:24]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 09:09:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 09:35:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 09:35:26]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-08-30 11:25:56]

https://codereview.chromium.org/2293803002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2293803002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:872: DeclarationScope* scope =
NewFunctionScope(FunctionKind::kArrowFunction);
here ^^^ the name is reused, which is confusing

[marja, 2016-08-30 11:28:21]

lgtm % comments

https://codereview.chromium.org/2293803002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2293803002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:673: DCHECK(outer);
Nit: DCHECK_NOT_NULL

https://codereview.chromium.org/2293803002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:930: DCHECK_EQ(this->scope(), outer);
Can this now be scope() instead of this->scope() or is scope still in scope?

[jochen (gone - plz use gerrit), 2016-08-30 11:30:38]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-08-30 11:30:38]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2293803002/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2016-08-30 11:30:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 11:53:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 11:53:43]

Description was changed from

==========
Don't reuse the name scope for multiple variables in DoParseLazy

R=marja@chromium.org,verwaest@chromium.org
BUG=
==========

to

==========
Don't reuse the name scope for multiple variables in DoParseLazy

R=marja@chromium.org,verwaest@chromium.org
BUG=

Committed: https://crrev.com/1992d72bbee90ce9a1fe64056a6defb7129fe32f
Cr-Commit-Position: refs/heads/master@{#39008}
==========

[commit-bot: I haz the power, 2016-08-30 11:53:44]

Patchset 2 (id:??) landed as
https://crrev.com/1992d72bbee90ce9a1fe64056a6defb7129fe32f
Cr-Commit-Position: refs/heads/master@{#39008}