chrome/browser/resources/extensions/extension_error.html - Issue 22938005: Add ErrorConsole UI for Extension Install Warnings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/extensions/extension_error.html

Issue 22938005: Add ErrorConsole UI for Extension Install Warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_install_warnings

Patch Set: Requested UI Changes Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/extensions/extension_error.css ('K') | « chrome/browser/resources/extensions/extension_error.css ('k') | chrome/browser/resources/extensions/extension_error.js » ('j') | chrome/browser/resources/extensions/extension_error.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 Copyright 2013 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be found

	4 in the LICENSE file.

	5 -->

	6 <div id="template-collection-extension-error" hidden>

	7 <div class="extension-error-list">

	8 <span i18n-content="extensionErrorsManifestErrors"></span>

	9 <ul class="extension-error-list-contents"></ul>

	10 <div class="extension-error-list-show-more">

	11 <a i18n-content="extensionErrorsShowMore" hidden></a>

	12 </div>

	13 </div>

	14 <div class="extension-error-metadata">

	15 <img class="extension-error-icon"></img>
	Dan Beam 2013/08/29 00:24:30 using img with an empty [src] can (possibly) reloa using img with an empty [src] can (possibly) reload the relative URL "", which is the same page (which reloads the same page, etc.). I recommend doing any image creation in JS instead. Devlin 2013/08/29 21:02:04 Done. Show quoted text On 2013/08/29 00:24:30, Dan Beam (OOO until 9-23) wrote: > using img with an empty [src] can (possibly) reload the relative URL "", which > is the same page (which reloads the same page, etc.). I recommend doing any > image creation in JS instead. Done.
	16 <span class="extension-error-message"></span>

	17 </div>

	18 </div>

OLD	NEW