Add ErrorConsole UI for Extension Install Warnings

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+<include src="extension_error.js"></include>
+
 cr.define('options', function() {
   'use strict';
 
   /**
-   * A lookup helper function to find the first node that has an id (starting
-   * at |node| and going up the parent chain).
-   * @param {Element} node The node to start looking at.
-   */
-  function findIdNode(node) {
-    while (node && !node.id) {
-      node = node.parentNode;
-    }
-    return node;
-  }
-
-  /**
    * Creates a new list of extensions.
    * @param {Object=} opt_propertyBag Optional properties.
    * @constructor
    * @extends {cr.ui.div}
    */
   var ExtensionsList = cr.ui.define('div');
 
   /**
    * @type {Object.<string, boolean>} A map from extension id to a boolean
    *     indicating whether the incognito warning is showing. This persists
@@ skipping 284 matching lines @@
       // The extension warnings (describing runtime issues).
       if (extension.warnings) {
         var panel = node.querySelector('.extension-warnings');
         panel.hidden = false;
         var list = panel.querySelector('ul');
         extension.warnings.forEach(function(warning) {
           list.appendChild(document.createElement('li')).innerText = warning;
         });
       }
 
-      // The install warnings.
-      if (extension.installWarnings) {
-        var panel = node.querySelector('.install-warnings');
-        panel.hidden = false;
-        var list = panel.querySelector('ul');
-        extension.installWarnings.forEach(function(warning) {
-          var li = document.createElement('li');
-          li.innerText = warning.message;
-          list.appendChild(li);
-        });
+      // The manifest errors and warnings.
+      if (extension.manifestErrors) {
+        node.querySelector('.manifest-errors').hidden = false;

[Dan Beam, 2013/08/20 21:39:26]

nit: only query selector once, IMO

var errors = node.querySelector('.manifest-errors');
errors.hidden = false;
errors.appendChild(
    new extensions.ExtensionErrorList(extension.manifestErrors));

[Devlin, 2013/08/20 23:06:51]

Done.

+        node.querySelector('.manifest-errors').appendChild(
+            new extensions.ExtensionErrorList(extension.manifestErrors));
       }
 
       this.appendChild(node);
       if (location.hash.substr(1) == extension.id) {
         // Scroll beneath the fixed header so that the extension is not
         // obscured.
         var topScroll = node.offsetTop - $('page-header').offsetHeight;
         var pad = parseInt(getComputedStyle(node, null).marginTop, 10);
         if (!isNaN(pad))
           topScroll -= pad / 2;
         document.body.scrollTop = topScroll;
       }
-    }
+    },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });