chrome/browser/resources/extensions/extension_error_overlay.html - Issue 22938005: Add ErrorConsole UI for Extension Install Warnings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/extensions/extension_error_overlay.html

Issue 22938005: Add ErrorConsole UI for Extension Install Warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_install_warnings

Patch Set: Yoyo's + temporarily remove *.png for apply issue Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/extensions/extension_error.js ('K') | « chrome/browser/resources/extensions/extension_error_overlay.css ('k') | chrome/browser/resources/extensions/extension_error_overlay.js » ('j') | chrome/browser/resources/extensions/extension_error_overlay.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 * Copyright 2013 The Chromium Authors. All rights reserved.

	3 * Use of this source code is governed by a BSD-style license that can be found

	4 * in the LICENSE file.

	5 -->

	6 <div id="extensionErrorOverlay" class="page">
	Dan Beam 2013/08/20 21:39:26 ids-like-this, i.e. extension-error-overlay ids-like-this, i.e. extension-error-overlay Devlin 2013/08/20 23:06:51 Following nearby code strikes again. Note to self: Show quoted text On 2013/08/20 21:39:26, Dan Beam wrote: > ids-like-this, i.e. extension-error-overlay Following nearby code strikes again. Note to self: fix extension_commands_overlay.html to match in a smaller CL. Done. Dan Beam 2013/08/21 23:41:03 yes and that'd be great (this is spelled out in th Show quoted text On 2013/08/20 23:06:51, D Cronin wrote: > On 2013/08/20 21:39:26, Dan Beam wrote: > > ids-like-this, i.e. extension-error-overlay > > Following nearby code strikes again. Note to self: fix > extension_commands_overlay.html to match in a smaller CL. > Done. yes and that'd be great (this is spelled out in the style guide but we haven't made mass fixes yet: http://www.chromium.org/developers/web-development-style-guide)
	7 <div class="close-button"></div>

	8 <h1 class="extension-error-overlay-title"></h1>

	9 <div class="content-area" id="extensionErrorOverlayContent"></div>
	Dan Beam 2013/08/20 21:39:26 extension-error-overlay-content extension-error-overlay-content Devlin 2013/08/20 23:06:51 Done. Show quoted text On 2013/08/20 21:39:26, Dan Beam wrote: > extension-error-overlay-content Done.
	10 <div class="action-area">

	11 <div class="action-area-right">

	12 <div class="button-strip">

	13 <button id="extensionErrorOverlayDismiss" i18n-content="ok"></button>
	Dan Beam 2013/08/20 21:39:26 extension-error-overlay-dismiss extension-error-overlay-dismiss Devlin 2013/08/20 23:06:51 Done. Show quoted text On 2013/08/20 21:39:26, Dan Beam wrote: > extension-error-overlay-dismiss Done.
	14 </div>

	15 </div>

	16 </div>

	17 </div>

OLD	NEW