Fix the stack trace when there are C++ frames in between dart frames.

runtime/vm/exceptions.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/exceptions.h"
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/flags.h"
@@ skipping 184 matching lines @@
                                  uword* handler_sp,
                                  uword* handler_fp,
                                  StacktraceBuilder* builder) {
   StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
   StackFrame* frame = frames.NextFrame();
   ASSERT(frame != NULL);  // We expect to find a dart invocation frame.
   Function& func = Function::Handle();
   Code& code = Code::Handle();
   Smi& offset = Smi::Handle();
   bool handler_found = false;
-  while (!frame->IsEntryFrame()) {
-    if (frame->IsDartFrame()) {
-      code = frame->LookupDartCode();
-      if (code.is_optimized()) {
-        // For optimized frames, extract all the inlined functions if any
-        // into the stack trace.
-        for (InlinedFunctionsIterator it(frame); !it.Done(); it.Advance()) {
-          func = it.function();
-          code = it.code();
-          uword pc = it.pc();
-          ASSERT(pc != 0);
-          ASSERT(code.EntryPoint() <= pc);
-          ASSERT(pc < (code.EntryPoint() + code.Size()));
+  bool handler_pc_set = false;
+  while (frame != NULL) {
+    while (!frame->IsEntryFrame()) {
+      if (frame->IsDartFrame()) {
+        code = frame->LookupDartCode();
+        if (code.is_optimized()) {
+          // For optimized frames, extract all the inlined functions if any
+          // into the stack trace.
+          for (InlinedFunctionsIterator it(frame); !it.Done(); it.Advance()) {
+            func = it.function();
+            code = it.code();
+            uword pc = it.pc();
+            ASSERT(pc != 0);
+            ASSERT(code.EntryPoint() <= pc);
+            ASSERT(pc < (code.EntryPoint() + code.Size()));
+            if (ShouldShowFunction(func)) {
+              offset = Smi::New(pc - code.EntryPoint());
+              builder->AddFrame(func, code, offset, handler_found);
+            }
+          }
+        } else {
+          offset = Smi::New(frame->pc() - code.EntryPoint());
+          func = code.function();
           if (ShouldShowFunction(func)) {
-            offset = Smi::New(pc - code.EntryPoint());
             builder->AddFrame(func, code, offset, handler_found);
           }
         }
-      } else {
-        offset = Smi::New(frame->pc() - code.EntryPoint());
-        func = code.function();
-        if (ShouldShowFunction(func)) {
-          builder->AddFrame(func, code, offset, handler_found);
+        if (!handler_pc_set && frame->FindExceptionHandler(handler_pc)) {
+          handler_pc_set = true;
+          *handler_sp = frame->sp();
+          *handler_fp = frame->fp();
+          handler_found = true;
+          if (!builder->FullStacktrace()) {
+            return handler_found;
+          }
         }
       }
-      if (!handler_found && frame->FindExceptionHandler(handler_pc)) {
-        *handler_sp = frame->sp();
-        *handler_fp = frame->fp();
-        handler_found = true;
-        if (!builder->FullStacktrace()) {
-          return handler_found;
-        }
-      }
+      frame = frames.NextFrame();
+      ASSERT(frame != NULL);
+    }
+    ASSERT(frame->IsEntryFrame());
+    if (!handler_pc_set) {
+      handler_pc_set = true;
+      *handler_pc = frame->pc();
+      *handler_sp = frame->sp();
+      *handler_fp = frame->fp();
+    }
+    if (!builder->FullStacktrace()) {

[Ivan Posva, 2013/08/13 00:04:25]

Move inside the if.

[siva, 2013/08/13 00:16:02]

Done.

+      return handler_found;
     }
     frame = frames.NextFrame();
-    ASSERT(frame != NULL);
-  }
-  ASSERT(frame->IsEntryFrame());
-  if (!handler_found) {
-    *handler_pc = frame->pc();
-    *handler_sp = frame->sp();
-    *handler_fp = frame->fp();
   }
   return handler_found;

[Ivan Posva, 2013/08/13 00:04:25]

Please rename to dart_handler_found.

[siva, 2013/08/13 00:16:02]

Done.

 }
 
 
 static void FindErrorHandler(uword* handler_pc,
                              uword* handler_sp,
                              uword* handler_fp) {
   // TODO(turnidge): Is there a faster way to get the next entry frame?
   StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
   StackFrame* frame = frames.NextFrame();
   ASSERT(frame != NULL);
@@ skipping 442 matching lines @@
       break;
   }
 
   return DartLibraryCalls::InstanceCreate(library,
                                           *class_name,
                                           *constructor_name,
                                           arguments);
 }
 
 }  // namespace dart