Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2293793002: Make Site Engagement behave for adding 0 points. (Closed)

Created:
4 years, 3 months ago by calamity
Modified:
4 years, 3 months ago
Reviewers:
dominickn
CC:
chromium-reviews, dominickn+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Site Engagement behave for adding 0 points. This CL changes the site engagement service to allow adding 0 points as a no-op. This will allow us to turn off engagement sources via Finch by setting them to 0. BUG=642265 Committed: https://crrev.com/f73cdba299e7e52a15d6bffbf874a94732dc47cb Cr-Commit-Position: refs/heads/master@{#416488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/engagement/site_engagement_service.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/engagement/site_engagement_service_unittest.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
calamity
4 years, 3 months ago (2016-09-02 06:31:36 UTC) #2
dominickn
lgtm
4 years, 3 months ago (2016-09-02 06:37:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293793002/1
4 years, 3 months ago (2016-09-05 01:59:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 02:46:08 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 02:48:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f73cdba299e7e52a15d6bffbf874a94732dc47cb
Cr-Commit-Position: refs/heads/master@{#416488}

Powered by Google App Engine
This is Rietveld 408576698