Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2293783002: Convert editing/inserting/return-key-with-selection-00[123].html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/return-key-with-selection-00[123].html to use w3c test harness This patch converts "editing/inserting/return-key-with-selection-00[123].html" to use w3c test harness to simplify test script for improving readability, and consolidates into "return_key_with_selection.html" since these files use similar test sample. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/8557b5029b080915027dbdf409fb49b2d38bacfe Cr-Commit-Position: refs/heads/master@{#415265}

Patch Set 1 : 2016-08-30T15:40:09 #

Total comments: 4

Patch Set 2 : 2016-08-30T17:29:28 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -312 lines) Patch
D third_party/WebKit/LayoutTests/editing/inserting/return-key-with-selection-001.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/return-key-with-selection-002.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/return-key-with-selection-003.html View 1 chunk +0 lines, -62 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/inserting/return_key_with_selection.html View 1 1 chunk +63 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/return-key-with-selection-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/return-key-with-selection-003-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/return-key-with-selection-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/return-key-with-selection-003-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/return-key-with-selection-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/return-key-with-selection-003-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-08-30 07:37:06 UTC) #5
Xiaocheng
https://codereview.chromium.org/2293783002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/return_key_with_selection.html File third_party/WebKit/LayoutTests/editing/inserting/return_key_with_selection.html (right): https://codereview.chromium.org/2293783002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/return_key_with_selection.html#newcode10 third_party/WebKit/LayoutTests/editing/inserting/return_key_with_selection.html:10: '<div>foo</div><div>^bar</div>|<div>baz</div></div>', There is an extra </div>. And should the ...
4 years, 3 months ago (2016-08-30 08:04:45 UTC) #6
yosin_UTC9
PTAL https://codereview.chromium.org/2293783002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/return_key_with_selection.html File third_party/WebKit/LayoutTests/editing/inserting/return_key_with_selection.html (right): https://codereview.chromium.org/2293783002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/return_key_with_selection.html#newcode10 third_party/WebKit/LayoutTests/editing/inserting/return_key_with_selection.html:10: '<div>foo</div><div>^bar</div>|<div>baz</div></div>', On 2016/08/30 at 08:04:45, Xiaocheng wrote: > ...
4 years, 3 months ago (2016-08-30 08:33:04 UTC) #11
Xiaocheng
lgtm
4 years, 3 months ago (2016-08-30 09:17:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293783002/20001
4 years, 3 months ago (2016-08-30 09:22:19 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 10:33:35 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 10:35:44 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8557b5029b080915027dbdf409fb49b2d38bacfe
Cr-Commit-Position: refs/heads/master@{#415265}

Powered by Google App Engine
This is Rietveld 408576698