Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2293763002: Revert of Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi files. (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi files. (patchset #1 id:1 of https://codereview.chromium.org/2278093004/ ) Reason for revert: This causes warning if files are referenced in gyp file. https://codereview.chromium.org/2285703003/ triggered presubmit when it shouln't have. Original issue's description: > Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi files. > > Add a presubmit check that warns when new source files are > not added to GN or gypi files. Check is done on upload only before gni includes are fixed. > > BUG=112371 > > Committed: https://crrev.com/1efc2f5f650a355056a98b6c99d4d0260742a750 > Cr-Commit-Position: refs/heads/master@{#414975} TBR=dpranke@chromium.org,maksim.sisov@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=112371 Committed: https://crrev.com/b229a7da7cedc5950b4f038503d42f04cd8c9d88 Cr-Commit-Position: refs/heads/master@{#415166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -47 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sky
Created Revert of Reland [Presubmit tests] Warn when new source files are not added to ...
4 years, 3 months ago (2016-08-30 03:33:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293763002/1
4 years, 3 months ago (2016-08-30 03:46:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 05:37:17 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:40:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b229a7da7cedc5950b4f038503d42f04cd8c9d88
Cr-Commit-Position: refs/heads/master@{#415166}

Powered by Google App Engine
This is Rietveld 408576698