Source/bindings/scripts/v8_utilities.py - Issue 229373006: Support optional, non-defaulted constructor arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_utilities.py

Issue 229373006: Support optional, non-defaulted constructor arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code adjustments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_utilities.py

diff --git a/Source/bindings/scripts/v8_utilities.py b/Source/bindings/scripts/v8_utilities.py

index cc64be4f916636c7e3972f23b32bc1e31e01402a..0281e7d5964cbdd456f59b54a7d766547a4ce548 100644

--- a/Source/bindings/scripts/v8_utilities.py

+++ b/Source/bindings/scripts/v8_utilities.py

@@ -113,7 +113,7 @@ def scoped_name(interface, definition, base_name):

partial_interface_implemented_as = definition.extended_attributes.get('PartialInterfaceImplementedAs')

if partial_interface_implemented_as:

return '%s::%s' % (partial_interface_implemented_as, base_name)

- if definition.is_static:

+ if definition.is_static or definition.name in ('Constructor', 'NamedConstructor'):

Nils Barth (inactive) 2014/04/10 01:53:26 Could you add a linebreak here? It's a bit more le

sof 2014/04/10 06:16:40 Done (but it was clear as could be before.)

Nils Barth (inactive) 2014/04/10 07:34:06 Thanks for accommodating my picky requests; (Rietv

return '%s::%s' % (cpp_name(interface), base_name)

return 'impl->%s' % base_name

« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | Source/bindings/templates/methods.cpp » ('J')