Refactor Node::showTree*() functions.

Refactor Node::showTree*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
they are used with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

This CL doesn't affect production.

BUG=638849
Committed: https://crrev.com/5186386bfed2c08c2253c65652f385859ed3af57
Cr-Commit-Position: refs/heads/master@{#415154}

[tkent, 2016-08-30 01:47:09]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2016-08-30 01:48:27]

Description was changed from

==========
Update Node::showTreeAndMark*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
we'd like to use these functions with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

BUG=638849
==========

to

==========
Update Node::showTree*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
we'd like to use these functions with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

BUG=638849
==========

[tkent, 2016-08-30 01:48:45]

Description was changed from

==========
Update Node::showTree*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
we'd like to use these functions with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

BUG=638849
==========

to

==========
Update Node::showTree*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
we'd like to use these functions with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

This CL doesn't affect production.

BUG=638849
==========

[tkent, 2016-08-30 01:49:04]

Patchset #1 (id:1) has been deleted

[tkent, 2016-08-30 01:55:50]

Description was changed from

==========
Update Node::showTree*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
we'd like to use these functions with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

This CL doesn't affect production.

BUG=638849
==========

to

==========
Update Node::showTree*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
they are used with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

This CL doesn't affect production.

BUG=638849
==========

[tkent, 2016-08-30 02:18:56]

Description was changed from

==========
Update Node::showTree*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
they are used with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

This CL doesn't affect production.

BUG=638849
==========

to

==========
Refactor Node::showTree*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
they are used with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

This CL doesn't affect production.

BUG=638849
==========

[commit-bot: I haz the power, 2016-08-30 02:48:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-30 03:55:31]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-08-30 03:55:32]

yosin@, would you review this please?
I think the next CL actually removes WTFLogAlways() usage from
core/{dom,editing}/.

[yosin_UTC9, 2016-08-30 04:55:02]

lgtm

[tkent, 2016-08-30 04:59:55]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-08-30 04:59:58]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-08-30 05:00:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:26:33]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-08-30 05:28:59]

Description was changed from

==========
Refactor Node::showTree*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
they are used with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

This CL doesn't affect production.

BUG=638849
==========

to

==========
Refactor Node::showTree*() functions.

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
they are used with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

This CL doesn't affect production.

BUG=638849

Committed: https://crrev.com/5186386bfed2c08c2253c65652f385859ed3af57
Cr-Commit-Position: refs/heads/master@{#415154}
==========

[commit-bot: I haz the power, 2016-08-30 05:29:01]

Patchset 1 (id:??) landed as
https://crrev.com/5186386bfed2c08c2253c65652f385859ed3af57
Cr-Commit-Position: refs/heads/master@{#415154}