Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2293683002: CrOS "remove this user" button should use red button style just like desktop browser (Closed)

Created:
4 years, 3 months ago by Qiang(Joe) Xu
Modified:
4 years, 3 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CrOS "remove this user" button should use red button style just like desktop browser Remove this user button for supervised user is changed to back bold font style not by design. This CL restores the red button style for both removing non-owner user and supervised user. BUG=641137 TEST=device test. Screenshots are in crbug.com/641137. Committed: https://crrev.com/b316f87f5c0d4bb686c66867dded237fcc2275e4 Cr-Commit-Position: refs/heads/master@{#415570}

Patch Set 1 #

Total comments: 2

Patch Set 2 : define style module using the dom-module #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M ui/login/account_picker/user_pod_row.css View 1 chunk +0 lines, -4 lines 0 comments Download
A ui/login/account_picker/user_pod_template.css View 1 1 chunk +20 lines, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_template.html View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Qiang(Joe) Xu
Hi Alexander, could you help review on this? Thanks!
4 years, 3 months ago (2016-08-29 21:24:16 UTC) #4
Alexander Alekseev
https://codereview.chromium.org/2293683002/diff/1/ui/login/account_picker/user_pod_template.html File ui/login/account_picker/user_pod_template.html (right): https://codereview.chromium.org/2293683002/diff/1/ui/login/account_picker/user_pod_template.html#newcode1 ui/login/account_picker/user_pod_template.html:1: <style is="custom-style"> Please, move this style to a .css ...
4 years, 3 months ago (2016-08-31 00:52:29 UTC) #5
Qiang(Joe) Xu
Hi Alexander, thanks for the help. New patch is uploaded. https://codereview.chromium.org/2293683002/diff/1/ui/login/account_picker/user_pod_template.html File ui/login/account_picker/user_pod_template.html (right): https://codereview.chromium.org/2293683002/diff/1/ui/login/account_picker/user_pod_template.html#newcode1 ...
4 years, 3 months ago (2016-08-31 05:02:25 UTC) #8
Alexander Alekseev
Thank you! lgtm
4 years, 3 months ago (2016-08-31 05:06:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293683002/20001
4 years, 3 months ago (2016-08-31 05:45:50 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 05:49:36 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 05:51:45 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b316f87f5c0d4bb686c66867dded237fcc2275e4
Cr-Commit-Position: refs/heads/master@{#415570}

Powered by Google App Engine
This is Rietveld 408576698