Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4923)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 229363002: Componentize TranslateUIDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 78357350670a4c03a2122219c715146ecd01406e..37426685dbcab0c93b7a9358e66d76187c88d3f6 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -28,7 +28,6 @@
#include "chrome/browser/themes/theme_service.h"
#include "chrome/browser/themes/theme_service_factory.h"
#include "chrome/browser/translate/translate_tab_helper.h"
-#include "chrome/browser/translate/translate_ui_delegate.h"
#include "chrome/browser/ui/bookmarks/bookmark_editor.h"
#include "chrome/browser/ui/bookmarks/bookmark_utils.h"
#include "chrome/browser/ui/browser.h"
@@ -80,6 +79,7 @@
#include "chrome/common/extensions/command.h"
#include "chrome/common/profile_management_switches.h"
#include "chrome/common/url_constants.h"
+#include "components/translate/core/browser/translate_ui_delegate.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/render_widget_host_view.h"
@@ -1790,8 +1790,11 @@ enum {
TranslateTabHelper::GetTranslateLanguages(contents,
&sourceLanguage, &targetLanguage);
- scoped_ptr<TranslateUIDelegate> uiDelegate(
- new TranslateUIDelegate(contents, sourceLanguage, targetLanguage));
+ scoped_ptr<TranslateUIDelegate> uiDelegate(new TranslateUIDelegate(
+ TranslateTabHelper::FromWebContents(contents),
+ TranslateTabHelper::GetManagerFromWebContents(contents),
+ sourceLanguage,
+ targetLanguage));
scoped_ptr<TranslateBubbleModel> model(
new TranslateBubbleModelImpl(step, uiDelegate.Pass()));
translateBubbleController_ = [[TranslateBubbleController alloc]

Powered by Google App Engine
This is Rietveld 408576698