chrome/browser/translate/translate_manager_render_view_host_unittest.cc - Issue 229363002: Componentize TranslateUIDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

Issue 229363002: Componentize TranslateUIDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/translate/translate_infobar_delegate.cc ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | chrome/browser/translate/translate_tab_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

diff --git a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

index 2badde082be749151167f84da1dd8b1ce994dbed..d5e428a79528237bee4bcf10388afb640b7a3ad9 100644

--- a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

+++ b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

@@ -387,8 +387,11 @@ class MockTranslateBubbleFactory : public TranslateBubbleFactory {

translate_tab_helper->GetLanguageState().original_language();

std::string target_language = TranslateDownloadManager::GetLanguageCode(

g_browser_process->GetApplicationLocale());

- scoped_ptr<TranslateUIDelegate> ui_delegate(new TranslateUIDelegate(

- web_contents, source_language, target_language));

+ scoped_ptr<TranslateUIDelegate> ui_delegate(

+ new TranslateUIDelegate(translate_tab_helper,

+ translate_tab_helper->GetTranslateManager(),

+ source_language,

+ target_language));

model_.reset(new TranslateBubbleModelImpl(step, ui_delegate.Pass()));

}