Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2293603002: [WebApk] Update verification keys. (Closed)

Created:
4 years, 3 months ago by hartmanng
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz, Xi Han, Yaron
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebApk] Update verification keys. Update keys to latest test keys and also break it out by channel. TBR=rsesek@chromium.org,yfriedman@chromium.org Committed: https://crrev.com/716cc589da62b7cc48ac0542fe01239808687ec9 Cr-Commit-Position: refs/heads/master@{#416339}

Patch Set 1 : Peter's original CL from https://codereview.chromium.org/2262333002/ #

Patch Set 2 : new keys #

Patch Set 3 : package private #

Patch Set 4 : fix test expectations #

Patch Set 5 : fix test again #

Patch Set 6 : final test fix... I hope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -74 lines) Patch
M chrome/android/BUILD.gn View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 2 chunks +1 line, -55 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHostSignature.template View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/android/webapk/channel_keys.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java View 1 2 3 4 5 6 chunks +14 lines, -13 lines 0 comments Download
M chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
hartmanng
Dan, can you please take a look? This is mostly a copy of Peter's https://codereview.chromium.org/2262333002/ ...
4 years, 3 months ago (2016-09-01 20:28:31 UTC) #6
hartmanng
apologies for the subject of the previous email
4 years, 3 months ago (2016-09-01 20:29:07 UTC) #7
gone
OWNER lgtm Looks like Robert approved the last one.
4 years, 3 months ago (2016-09-01 20:33:19 UTC) #8
hartmanng
On 2016/09/01 20:33:19, dfalcantara wrote: > OWNER lgtm > > Looks like Robert approved the ...
4 years, 3 months ago (2016-09-01 20:34:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293603002/60001
4 years, 3 months ago (2016-09-01 20:35:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/122629)
4 years, 3 months ago (2016-09-01 21:17:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293603002/80001
4 years, 3 months ago (2016-09-01 21:55:19 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/134917)
4 years, 3 months ago (2016-09-01 23:26:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293603002/140001
4 years, 3 months ago (2016-09-02 17:26:41 UTC) #22
commit-bot: I haz the power
Exceeded global retry quota
4 years, 3 months ago (2016-09-02 19:24:58 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293603002/140001
4 years, 3 months ago (2016-09-02 19:59:22 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:140001)
4 years, 3 months ago (2016-09-02 21:06:30 UTC) #28
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/716cc589da62b7cc48ac0542fe01239808687ec9 Cr-Commit-Position: refs/heads/master@{#416339}
4 years, 3 months ago (2016-09-02 21:08:19 UTC) #30
mdjones
4 years, 3 months ago (2016-09-02 23:03:13 UTC) #31
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:140001) has been created in
https://codereview.chromium.org/2309553002/ by mdjones@chromium.org.

The reason for reverting is: Build fails with: jmake: Could not find class file
for
/tmp/tmp7BuImL/java/org/chromium/browser/webapps/ChromeWebApkHostSignature.java.

Powered by Google App Engine
This is Rietveld 408576698