Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2293583002: Change includes of histogram.h to histogram_macros.h. (Closed)

Created:
4 years, 3 months ago by Alexei Svitkine (slow)
Modified:
4 years, 3 months ago
Reviewers:
Ilya Sherman, jam
CC:
chromium-reviews, asanka, msramek+watch_chromium.org, mcasas+watch+vc_chromium.org, zea+watch_chromium.org, tzik, posciak+watch_chromium.org, johnme+watch_chromium.org, nasko+codewatch_chromium.org, cbentzel+watch_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, markusheintz_, miu+watch_chromium.org, jbauman+watch_chromium.org, kinuko+cache_chromium.org, gavinp+disk_chromium.org, aboxhall+watch_chromium.org, jam, raymes+watch_chromium.org, nhiroki, je_julie, darin-cc_chromium.org, loading-reviews_chromium.org, kalyank, harkness+watch_chromium.org, creis+watch_chromium.org, cmumford, ntp-dev+reviews_chromium.org, tdresser+watch_chromium.org, Peter Beverloo, sievers+watch_chromium.org, Randy Smith (Not in Mondays), yuzo+watch_chromium.org, wfh+watch_chromium.org, feature-media-reviews_chromium.org, timvolodine, asvitkine+watch_chromium.org, mlamouri+watch-sensors_chromium.org, piman+watch_chromium.org, jsbell+idb_chromium.org, danakj+watch_chromium.org, sync-reviews_chromium.org, michaeln, Ian Vollick, riju_, nektar+watch_chromium.org, dtapuska+chromiumwatch_chromium.org, dtseng+watch_chromium.org, tfarina, cc-bugs_chromium.org, scheduler-bugs_chromium.org, kinuko+fileapi, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change includes of histogram.h to histogram_macros.h. This is another pass of migration of includes for users of histogram macros. This doesn't fully complete the migration, but gets us closer to the end result. A few files needed to include both headers as they use both macros and the raw API. BUG=416479 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=jam@chromium.org Committed: https://crrev.com/3033081a9215d91a7a22d586d5624b3747593769 Cr-Commit-Position: refs/heads/master@{#415067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -101 lines) Patch
M base/files/important_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/debug/frame_rate_counter.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/ca_layer_overlay.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/direct_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/compositor_timing_history.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/tile_draw_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/host_content_settings_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/content/browser/distiller_page_web_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/domain_reliability/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/download_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/in_memory_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/top_sites_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/web_history_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/memory_pressure/memory_pressure_stats_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/profiler/tracking_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/stability_metrics_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_tiles/most_visited_sites.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/browser/history_url_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/omnibox_edit_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/url_index_private_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/zero_suggest_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/default_search_pref_migration.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/session_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/signin_status_metrics_provider_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/spellcheck/browser/spellcheck_host_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/spellcheck/renderer/spellcheck_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core/shared_model_type_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core_impl/attachments/on_disk_attachment_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core_impl/sync_encryption_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core_impl/sync_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/startup_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/apply_control_data_updates.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/conflict_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/directory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/on_disk_directory_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/favicon_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/tracing/child/child_trace_message_filter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/user_prefs/tracked/tracked_preference_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/service/variations_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_state_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_state_impl_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_histograms.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cocoa/system_hotkey_helper_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_area.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/session_storage_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/histogram_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/push_messaging/push_messaging_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_discardable_shared_memory_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_histogram_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_database_observer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/mock_apple_keychain.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M device/battery/battery_status_manager_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/geolocation/wifi_data_provider_corewlan_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M gin/v8_initializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/checkin_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/memory_program_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_resampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/pipeline_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/stream_parser_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/eviction.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/dns_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_quality_estimator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/image_operations.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/skia_histogram.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/recovery.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/quota/quota_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/data_pack.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/event_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_touch_uma_histogram.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (19 generated)
Alexei Svitkine (slow)
Ilya, PTAL. I plan to TBR downstream owners.
4 years, 3 months ago (2016-08-29 18:27:14 UTC) #9
Alexei Svitkine (slow)
Actually, for OWNERS looks like jam@ is a top-level owner who still reviewers code, so ...
4 years, 3 months ago (2016-08-29 19:03:23 UTC) #15
Ilya Sherman
LGTM.
4 years, 3 months ago (2016-08-29 19:07:27 UTC) #16
Alexei Svitkine (slow)
jam@ is OOO today, so TBR'ing him (this is a downstream change of base/metrics)
4 years, 3 months ago (2016-08-29 19:49:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293583002/20001
4 years, 3 months ago (2016-08-29 20:27:24 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-08-30 04:01:30 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:04:33 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3033081a9215d91a7a22d586d5624b3747593769
Cr-Commit-Position: refs/heads/master@{#415067}

Powered by Google App Engine
This is Rietveld 408576698