Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2293553002: Disable tests in system_health_smoke_test that takes 100+ seconds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable flaky tests that take too long Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/scripts_smoke_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 19 matching lines...) Expand all
30 return list(b for b in sh_benchmark_classes if 30 return list(b for b in sh_benchmark_classes if
31 b.Name().startswith('system_health.memory')) 31 b.Name().startswith('system_health.memory'))
32 32
33 33
34 _DISABLED_TESTS = frozenset({ 34 _DISABLED_TESTS = frozenset({
35 # crbug.com/629123 35 # crbug.com/629123
36 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:hackernews', # pylint: disable=line-too-long 36 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:hackernews', # pylint: disable=line-too-long
37 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:nytimes', # pylint: disable=line-too-long 37 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:nytimes', # pylint: disable=line-too-long
38 # crbug.com/637230 38 # crbug.com/637230
39 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:cnn', # pylint: disable=line-too-long 39 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:cnn', # pylint: disable=line-too-long
40
41 # crbug.com/641934
42 # These tests are taking too long (more than 100s each).
43 # TODO(nedn): reenable these test once we have more capacity to run them on
44 # CQ.
45 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:flipboard', # pylint: disable=line-too-long
46 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:media:imgur', # pylint: disable=line-too-long
47 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:media:youtube', # pylint: disable=line-too-long
48 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:media:facebook_photos', # pylint: disable=line-too-lon g
49 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:reddit', # pylint: disable=line-too-long
50 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:social:facebook', # pylint: disable=line-too-long
51 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:news:cnn', # pylint: disable=line-too-long
40 }) 52 })
41 53
42 54
43 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 55 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
44 56
45 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 57 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
46 # 58 #
47 # This smoke test dynamically tests all system health user stories. So 59 # This smoke test dynamically tests all system health user stories. So
48 # disabling it for one failing or flaky benchmark would disable a much 60 # disabling it for one failing or flaky benchmark would disable a much
49 # wider swath of coverage than is usally intended. Instead, if a test is 61 # wider swath of coverage than is usally intended. Instead, if a test is
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 # parsed during test time which happens after load_tests are called. 137 # parsed during test time which happens after load_tests are called.
126 # Since none of our system health benchmarks creates stories based on 138 # Since none of our system health benchmarks creates stories based on
127 # command line options, it should be ok to pass options=None to 139 # command line options, it should be ok to pass options=None to
128 # CreateStorySet. 140 # CreateStorySet.
129 for story_to_smoke_test in ( 141 for story_to_smoke_test in (
130 benchmark_class().CreateStorySet(options=None).stories): 142 benchmark_class().CreateStorySet(options=None).stories):
131 suite.addTest( 143 suite.addTest(
132 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 144 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
133 145
134 return suite 146 return suite
OLDNEW
« no previous file with comments | « no previous file | tools/perf/scripts_smoke_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698