presubmit_canned_checks.py - Issue 2293523002: Add more debugging in presubmit owners check for Gerrit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 2293523002: Add more debugging in presubmit owners check for Gerrit. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 65e3185ea7abe8c70922c66c9889fde83e309890..b47629d2d9c442aced643036617856d4f3a75b09 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -999,6 +999,8 @@ def _GerritOwnerAndReviewers(input_api, email_regexp, approval_needed=False):

reviewers = set(

r for r in input_api.gerrit.GetChangeReviewers(issue, approval_needed)

if _match_reviewer_email(r, owner_email, email_regexp))

+ input_api.logging.debug('owner: %s; approvals given by: %s',

+ owner_email, ', '.join(sorted(reviewers)))

return owner_email, reviewers

« no previous file with comments | « no previous file | no next file » | no next file with comments »